Skip to content

Commit

Permalink
packages: Fix some JS lints ahead of the eslint 9 upgrade (#40497)
Browse files Browse the repository at this point in the history
To make the eslint 9 upgrade PR smaller, let's fix some of the lints
that it'll complain about ahead of time.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12239487817

Upstream-Ref: Automattic/jetpack@48167f7
  • Loading branch information
anomiex authored and matticbot committed Dec 9, 2024
1 parent d2c01be commit 1286bde
Show file tree
Hide file tree
Showing 31 changed files with 350 additions and 349 deletions.
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
"automattic/jetpack-jitm": "^4.0.2",
"automattic/jetpack-licensing": "^3.0.2",
"automattic/jetpack-logo": "^3.0.0",
"automattic/jetpack-masterbar": "^0.10.2",
"automattic/jetpack-my-jetpack": "^5.1.1",
"automattic/jetpack-masterbar": "^0.10.3-alpha",
"automattic/jetpack-my-jetpack": "^5.1.2-alpha",
"automattic/jetpack-plugins-installer": "^0.5.0",
"automattic/jetpack-post-list": "^0.7.1",
"automattic/jetpack-publicize": "^0.56.4-alpha",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -259,13 +259,11 @@ const ReviewMessage = connectionLoaded => {
strong: <strong></strong>,
}
) }
// eslint-disable-next-line react/jsx-no-bind
href={ getRedirectUrl( 'jetpack-backup-new-review' ) }
onClick={ trackSendToReview }
requestReason={ requestReason }
reviewText={ reviewText }
dismissedReview={ dismissedReview }
// eslint-disable-next-line react/jsx-no-bind
dismissMessage={ dismissMessage }
/>
</Col>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ const NoBackupCapabilities = () => {
ctaText={ __( 'Get VaultPress Backup', 'jetpack-backup-pkg' ) }
icon="data:image/svg+xml,%3Csvg width='32' height='32' fill='none' xmlns='http://www.w3.org/2000/svg'%3E%3Cpath fill-rule='evenodd' clip-rule='evenodd' d='m21.092 15.164.019-1.703v-.039c0-1.975-1.803-3.866-4.4-3.866-2.17 0-3.828 1.351-4.274 2.943l-.426 1.524-1.581-.065a2.92 2.92 0 0 0-.12-.002c-1.586 0-2.977 1.344-2.977 3.133 0 1.787 1.388 3.13 2.973 3.133H22.399c1.194 0 2.267-1.016 2.267-2.4 0-1.235-.865-2.19-1.897-2.368l-1.677-.29Zm-10.58-3.204a4.944 4.944 0 0 0-.201-.004c-2.75 0-4.978 2.298-4.978 5.133s2.229 5.133 4.978 5.133h12.088c2.357 0 4.267-1.97 4.267-4.4 0-2.18-1.538-3.99-3.556-4.339v-.06c0-3.24-2.865-5.867-6.4-5.867-2.983 0-5.49 1.871-6.199 4.404Z' fill='%23000'/%3E%3C/svg%3E"
infoText={ priceAfter === price ? basicInfoText : introductoryInfoText }
// eslint-disable-next-line react/jsx-no-bind
onCtaClick={ sendToCart }
priceAfter={ priceAfter }
priceBefore={ price }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ const BackupVideoSection = ( {
/>
</div>

{ /* eslint-disable-next-line jsx-a11y/media-has-caption */ }
<video poster={ backupVideoThumbnail } controls>
<source
src="https://videos.files.wordpress.com/VNRR7Mkj/audio_jetpack_backup_-3.mov"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ const ReviewRequest: React.FC< ReviewRequestBaseProps > = ( {
<Text className={ styles.cta }>{ cta }</Text>
</div>
</ExternalLink>
{ /* eslint-disable-next-line react/jsx-no-bind */ }
<a role="button" href="#" onClick={ dismissMessage } className={ styles.dismiss }>
{ __( 'Maybe later', 'jetpack-backup-pkg' ) }
</a>
Expand Down

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -1 +1 @@
<?php return array('dependencies' => array('jetpack-connection', 'jetpack-script-data', 'lodash', 'react', 'react-dom', 'react-jsx-runtime', 'wp-api-fetch', 'wp-components', 'wp-compose', 'wp-core-data', 'wp-data', 'wp-date', 'wp-element', 'wp-html-entities', 'wp-i18n', 'wp-plugins', 'wp-polyfill', 'wp-primitives', 'wp-url'), 'version' => '6692c151f97719eb119e');
<?php return array('dependencies' => array('jetpack-connection', 'jetpack-script-data', 'lodash', 'react', 'react-dom', 'react-jsx-runtime', 'wp-api-fetch', 'wp-components', 'wp-compose', 'wp-core-data', 'wp-data', 'wp-date', 'wp-element', 'wp-html-entities', 'wp-i18n', 'wp-plugins', 'wp-polyfill', 'wp-primitives', 'wp-url'), 'version' => '1cd1abc2f666c91672f9');

Large diffs are not rendered by default.

Loading

0 comments on commit 1286bde

Please sign in to comment.