Boost: remove wp-content/advanced-cache.php when Cache module is disa…

…bled (#37643)

* Remove advanced-cache.php when Cache module is disabled

* changelog

* Move the deactivate code into its own function

* Rename functions so they're more explicit about what they do

projects/plugins/boost/app/modules/optimizations/page-cache/Page_Cache.php

@@ -40,7 +40,8 @@ public function __construct() {
 	public function setup() {
 		Garbage_Collection::setup();
 
-		add_action( 'jetpack_boost_module_status_updated', array( $this, 'handle_module_status_updated' ), 10, 2 );
+		add_action( 'jetpack_boost_module_status_updated', array( $this, 'clear_cache_on_output_changing_module_toggle' ), 10, 2 );
+		add_action( 'jetpack_boost_module_status_updated', array( $this, 'delete_advanced_cache' ), 10, 2 );
 		add_action( 'jetpack_boost_critical_css_invalidated', array( $this, 'invalidate_cache' ) );
 		add_action( 'jetpack_boost_critical_css_generated', array( $this, 'invalidate_cache' ) );
 		add_action( 'update_option_' . JETPACK_BOOST_DATASYNC_NAMESPACE . '_minify_js_excludes', array( $this, 'invalidate_cache' ) );
@@ -53,7 +54,7 @@ public function setup() {
 	 *
 	 * @param string $module_slug The slug of the module that was updated.
 	 */
-	public function handle_module_status_updated( $module_slug, $status ) {
+	public function clear_cache_on_output_changing_module_toggle( $module_slug, $status ) {
 		// Get a list of modules that can change the HTML output.
 		$output_changing_modules = Modules_Index::get_modules_implementing( Changes_Page_Output::class );
 
@@ -71,6 +72,15 @@ public function handle_module_status_updated( $module_slug, $status ) {
 		}
 	}
 
+	/**
+	 * Handles the deactivation of the module by removing the advanced-cache.php file.
+	 */
+	public function delete_advanced_cache( $module_slug, $status ) {
+		if ( $module_slug === 'page_cache' && ! $status ) {
+			Page_Cache_Setup::delete_advanced_cache();
+		}
+	}
+
 	public function invalidate_cache() {
 		$cache = new Boost_Cache();
 		$cache->get_storage()->invalidate( home_url(), Filesystem_Utils::DELETE_ALL );

projects/plugins/boost/changelog/update-boost-page_cache_del_loader

@@ -0,0 +1,4 @@
+Significance: minor
+Type: added
+
+Boost: remove the advanced-cache.php when the Cache module is disabled