Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortlinks: Fix the UI in newer version of Gutenberg #15051

Merged
merged 2 commits into from
Apr 6, 2020
Merged

Shortlinks: Fix the UI in newer version of Gutenberg #15051

merged 2 commits into from
Apr 6, 2020

Conversation

apeatling
Copy link
Member

@apeatling apeatling commented Mar 19, 2020 •
edited by jeherve
Loading

Fixes #14982

Before:
Screen Shot 2020-03-19 at 12 01 42 PM

After:
Screen Shot 2020-03-19 at 12 01 26 PM

Testing instructions:

  • Make sure the Shortlinks module is active on your site.
  • Publish a post on a publicly accessable site
  • Hit the Jetpack logo in the editor
  • Make sure the button and textbox line up
  • Disable the Gutenberg plugin and make sure they still line up on the core WP version of Gutenberg.

Proposed changelog entry for your changes:

  • None

@apeatling apeatling added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Mar 19, 2020
@apeatling apeatling requested review from simison and a team March 19, 2020 19:08
@apeatling apeatling self-assigned this Mar 19, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello apeatling! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D40571-code before merging this PR. Thank you!

@jetpackbot
Copy link

jetpackbot commented Mar 19, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against ee61e14

@jeherve jeherve added this to the 8.4 milestone Mar 20, 2020
@matticbot
Copy link
Contributor

apeatling, Your synced wpcom patch D40571-code has been updated.

@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Mar 20, 2020
@apeatling
Copy link
Member Author

@simison Thanks for pointing me to the variables, super useful to know about those.

@matticbot
Copy link
Contributor

apeatling, Your synced wpcom patch D40571-code has been updated.

@matticbot
Copy link
Contributor

apeatling, Your synced wpcom patch D40571-code has been updated.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Apr 6, 2020
jeherve
jeherve approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to work well in my tests with WP 5.3.2, 5.4, and 5.4+Gutenberg. It should be good to merge.

I'd love to have another review on this though! :)

@jeherve jeherve merged commit fe54fe4 into master Apr 6, 2020
@jeherve jeherve deleted the fix/shortlink-button branch April 6, 2020 15:06
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 6, 2020
jeherve added a commit that referenced this pull request Apr 6, 2020
@apeatling @jeherve
[not verified] Shortlinks: Fix the UI in newer version of Gutenberg (#…
9664982 
…15051)

* Fix height of button/textbox for the shortlink UI in both older and newer versions of Gutenberg.

* Use CSS variable to control shortlink field

See https://github.com/Automattic/jetpack/pull/15051/files#r395531266

Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
@jeherve
Copy link
Member

jeherve commented Apr 6, 2020

Cherry-picked to branch-8.4 in 9664982

@jeherve
Copy link
Member

jeherve commented Apr 6, 2020

r205421-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glendaviesnz glendaviesnz glendaviesnz left review comments

@gziolo gziolo gziolo left review comments

@scruffian scruffian scruffian left review comments

@simison simison simison left review comments

@sergeymitr sergeymitr sergeymitr approved these changes

@jeherve jeherve jeherve approved these changes

Assignees

@apeatling apeatling

Labels
[Feature] Shortlinks [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.4
Development

Successfully merging this pull request may close these issues.

Short link: buttons are off in Gutenberg 7.7
9 participants
@apeatling @matticbot @jetpackbot @jeherve @simison @scruffian @gziolo @sergeymitr @glendaviesnz