-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calypsoify: Add test to fail under 9.2 #17942
Calypsoify: Add test to fail under 9.2 #17942
Conversation
* Include reserved branch name conventions in the documentation * Grammar are hard
I'll follow up with some minor production code changes to make this easier to test with confidence. This test would probably still pass in a situation where there masterbar is loaded elsewhere in the test run since it only makes sure the class exists. The production code probably can be tweaked to return an instance of the masterbar class, but I didn't want to touch production code for the sake of the test as part of something intended for a point release. |
This is an automated check which relies on |
See #17939
Adds an unit test to call the
mock_masterbar_activation
function to ensure it doesn't error.As it stands, this PR will fail. Coupled with 17939, it should pass.
Changes proposed in this Pull Request:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
No
Testing instructions:
yarn docker:phpunit --testsuite=calyposify
master
after that's merged, it should pass.Proposed changelog entry for your changes: