Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calypsoify: Add test to fail under 9.2 #17942

Merged
merged 3 commits into from
Dec 1, 2020

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Dec 1, 2020

See #17939

Adds an unit test to call the mock_masterbar_activation function to ensure it doesn't error.

As it stands, this PR will fail. Coupled with 17939, it should pass.

Changes proposed in this Pull Request:

  • Adds unit test.

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Unit tests should fail. You can test directly under yarn docker:phpunit --testsuite=calyposify
  • Merged into 17939 or into master after that's merged, it should pass.

Proposed changelog entry for your changes:

  • n/a

kraftbj and others added 3 commits December 1, 2020 09:55
@kraftbj kraftbj added this to the 9.2.1 milestone Dec 1, 2020
@kraftbj kraftbj added [Feature] Calypsoify Unit Tests [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended labels Dec 1, 2020
@kraftbj kraftbj self-assigned this Dec 1, 2020
@kraftbj kraftbj requested review from anomiex and jeherve December 1, 2020 16:59
@kraftbj kraftbj changed the title Calypsoify: Add test to fail under 9.2" Calypsoify: Add test to fail under 9.2 Dec 1, 2020
@kraftbj
Copy link
Contributor Author

kraftbj commented Dec 1, 2020

This branch by itself:
2020-12-01 at 11 01 AM

This branch merged into 17939:
2020-12-01 at 11 02 AM

@kraftbj kraftbj changed the base branch from master to fix/fatal-calypsoify-masterbar December 1, 2020 17:05
@kraftbj
Copy link
Contributor Author

kraftbj commented Dec 1, 2020

I'll follow up with some minor production code changes to make this easier to test with confidence. This test would probably still pass in a situation where there masterbar is loaded elsewhere in the test run since it only makes sure the class exists.

The production code probably can be tweaked to return an instance of the masterbar class, but I didn't want to touch production code for the sake of the test as part of something intended for a point release.

@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against b4412c2

@kraftbj kraftbj merged commit c652bc8 into fix/fatal-calypsoify-masterbar Dec 1, 2020
@kraftbj kraftbj deleted the add/masterbar-mock-test branch December 1, 2020 19:24
jeherve pushed a commit that referenced this pull request Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypsoify [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended Unit Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants