Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masterbar: update path to tracks resource #17994

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Dec 7, 2020

Fixes #17989

Changes proposed in this Pull Request:

In #17762 and #17783 we've refactored the Masterbar, but forgot to update the reference to the script that got moved along with this.

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Go to Jetpack > Settings > Writing
  • Enable the WordPress.com toolbar
  • On page reload, check your browser network tools; you should see _inc/build/masterbar/masterbar/tracks-events.min.js load properly.

Proposed changelog entry for your changes:

  • WordPress.com Toolbar: update resources' path.

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] High [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Status] Needs Cherry-Pick labels Dec 7, 2020
@jeherve jeherve added this to the 9.2.1 milestone Dec 7, 2020
@jeherve jeherve self-assigned this Dec 7, 2020
@jetpackbot
Copy link

jetpackbot commented Dec 7, 2020

Scheduled Jetpack release: December 10, 2020.
Scheduled code freeze: December 3, 2020

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against 5517a12

kraftbj
kraftbj previously approved these changes Dec 7, 2020
@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Dec 7, 2020
Fixes #17989

In #17762 and #17783 we've refactored the Masterbar, but forgot to update the reference to the script that got moved along with this.
@jeherve jeherve merged commit 31c99d1 into master Dec 8, 2020
@jeherve jeherve deleted the fix/masterbar-tracks-path branch December 8, 2020 11:27
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Dec 8, 2020
jeherve added a commit that referenced this pull request Dec 8, 2020
Fixes #17989

In #17762 and #17783 we've refactored the Masterbar, but forgot to update the reference to the script that got moved along with this.
@jeherve
Copy link
Member Author

jeherve commented Dec 8, 2020

Cherry-picked to branch-9.2 in 88c9463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WordPress.com Hosted/Atomic & Masterbar: 404s for /masterbar/tracks-masterbar/tracks-events.min.js
5 participants