Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wordpress/eslint-plugin #18624

Closed
wants to merge 6 commits into from
Closed

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Jan 30, 2021

See #16763 (comment)

Updates the eslint-plugin package specifically.
Fixes a couple of unrelated test errors from yarn lint-required.

Changes proposed in this Pull Request:

  • Updates wordpress/eslint-plugin

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

n/a

Testing instructions:

  • Run yarn lint-required and see various unsafe api usages in blocks.

Proposed changelog entry for your changes:

  • Compatibility: Ensure Jetpack is not using experimental JS exports.

@kraftbj kraftbj added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Janitorial labels Jan 30, 2021
@jetpackbot
Copy link

jetpackbot commented Jan 30, 2021

Scheduled Jetpack release: February 16, 2021.
Scheduled code freeze: February 8, 2021

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against 135a251

@kraftbj kraftbj mentioned this pull request Jan 30, 2021
1 task
@kraftbj
Copy link
Contributor Author

kraftbj commented Jan 30, 2021

/home/runner/work/jetpack/jetpack/projects/plugins/jetpack/_inc/client/lib/locale/index.js
  4:10  error  Usage of `__experimentalGetSettings` from `@wordpress/date` is not allowed.
See developer.wordpress.org/block-editor/contributors/develop/coding-guidelines/#experimental-and-unstable-apis for details  @wordpress/no-unsafe-wp-apis

/home/runner/work/jetpack/jetpack/projects/plugins/jetpack/extensions/blocks/business-hours/edit.js
  7:10  error  Usage of `__experimentalGetSettings` from `@wordpress/date` is not allowed.
See developer.wordpress.org/block-editor/contributors/develop/coding-guidelines/#experimental-and-unstable-apis for details  @wordpress/no-unsafe-wp-apis

/home/runner/work/jetpack/jetpack/projects/plugins/jetpack/extensions/blocks/button/button-colors-panel.js
  7:2  error  Usage of `__experimentalPanelColorGradientSettings` from `@wordpress/block-editor` is not allowed.
See developer.wordpress.org/block-editor/contributors/develop/coding-guidelines/#experimental-and-unstable-apis for details  @wordpress/no-unsafe-wp-apis

/home/runner/work/jetpack/jetpack/projects/plugins/jetpack/extensions/blocks/button/constants.js
  5:10  error  Usage of `__experimentalUseGradient` from `@wordpress/block-editor` is not allowed.
See developer.wordpress.org/block-editor/contributors/develop/coding-guidelines/#experimental-and-unstable-apis for details  @wordpress/no-unsafe-wp-apis

/home/runner/work/jetpack/jetpack/projects/plugins/jetpack/extensions/blocks/button/edit.js
  12:2  error  Usage of `__experimentalUseGradient` from `@wordpress/block-editor` is not allowed.
See developer.wordpress.org/block-editor/contributors/develop/coding-guidelines/#experimental-and-unstable-apis for details  @wordpress/no-unsafe-wp-apis

/home/runner/work/jetpack/jetpack/projects/plugins/jetpack/extensions/blocks/button/save.js
  11:2  error  Usage of `__experimentalGetGradientClass` from `@wordpress/block-editor` is not allowed.
See developer.wordpress.org/block-editor/contributors/develop/coding-guidelines/#experimental-and-unstable-apis for details  @wordpress/no-unsafe-wp-apis

/home/runner/work/jetpack/jetpack/projects/plugins/jetpack/extensions/blocks/contact-form/edit.js
  17:2  error  Usage of `__experimentalBlockVariationPicker` from `@wordpress/block-editor` is not allowed.
See developer.wordpress.org/block-editor/contributors/develop/coding-guidelines/#experimental-and-unstable-apis for details  @wordpress/no-unsafe-wp-apis

/home/runner/work/jetpack/jetpack/projects/plugins/jetpack/extensions/blocks/premium-content/buttons/edit.js
  5:23  error  Usage of `__experimentalBlock` from `@wordpress/block-editor` is not allowed.
See developer.wordpress.org/block-editor/contributors/develop/coding-guidelines/#experimental-and-unstable-apis for details  @wordpress/no-unsafe-wp-apis

/home/runner/work/jetpack/jetpack/projects/plugins/jetpack/extensions/blocks/premium-content/login-button/edit.js
  12:39  error  Usage of `__experimentalBlock` from `@wordpress/block-editor` is not allowed.
See developer.wordpress.org/block-editor/contributors/develop/coding-guidelines/#experimental-and-unstable-apis for details  @wordpress/no-unsafe-wp-apis

/home/runner/work/jetpack/jetpack/projects/plugins/jetpack/extensions/blocks/subscriptions/deprecated/v3/get-subscriptions-shortcode.js
  7:2  error  Usage of `__experimentalGetGradientClass` from `@wordpress/block-editor` is not allowed.
See developer.wordpress.org/block-editor/contributors/develop/coding-guidelines/#experimental-and-unstable-apis for details  @wordpress/no-unsafe-wp-apis

/home/runner/work/jetpack/jetpack/projects/plugins/jetpack/extensions/blocks/subscriptions/save.js
  7:2  error  Usage of `__experimentalGetGradientClass` from `@wordpress/block-editor` is not allowed.
See developer.wordpress.org/block-editor/contributors/develop/coding-guidelines/#experimental-and-unstable-apis for details  @wordpress/no-unsafe-wp-apis

/home/runner/work/jetpack/jetpack/projects/plugins/jetpack/extensions/blocks/videopress/edit.js
  24:2  error  Usage of `__experimentalBlock` from `@wordpress/block-editor` is not allowed.
See developer.wordpress.org/block-editor/contributors/develop/coding-guidelines/#experimental-and-unstable-apis for details  @wordpress/no-unsafe-wp-apis

/home/runner/work/jetpack/jetpack/projects/plugins/jetpack/extensions/shared/components/number-control/index.jsx
  6:2  error  Usage of `__experimentalNumberControl` from `@wordpress/components` is not allowed.
See developer.wordpress.org/block-editor/contributors/develop/coding-guidelines/#experimental-and-unstable-apis for details  @wordpress/no-unsafe-wp-apis

There are some other import/no-unresolved that I'm seeing via the action that I didn't see locally. I think that's due to the action not yarn installing the project.

@kraftbj
Copy link
Contributor Author

kraftbj commented Feb 6, 2021

The two __experimentalBlock likely could be replaced with useBlockProps. https://github.com/WordPress/gutenberg/blob/812a926560db43d0c35eb8fdb393b428b40dbd80/packages/block-editor/src/components/block-list/block-wrapper.js#L15-L16

anomiex
anomiex previously approved these changes Feb 25, 2021
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward enough and CI was happy, let's try it.

But it looks like it needs another master merge.

@anomiex anomiex added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 25, 2021
@github-actions github-actions bot added [Block] Paid Content aka Premium Content [Block] VideoPress [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Mar 11, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


If you are an automattician, once your PR is ready for review add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.undefined


jetpack plugin:

  • Next scheduled release: April 6, 2021.
  • Scheduled code freeze: March 29, 2021

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello kraftbj! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D58571-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jeherve
Copy link
Member

jeherve commented Mar 2, 2022

I'll close this PR for now because of the lack of activity on this. We can always reopen in the future if needed, but it will need a rebase, so it may be easier to start a new PR at this point.

@jeherve jeherve closed this Mar 2, 2022
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Paid Content aka Premium Content [Block] VideoPress [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants