Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add button width options for Jetpack Button and Subscriptions Form #18809

Merged
merged 16 commits into from
Mar 12, 2021
Merged

Add button width options for Jetpack Button and Subscriptions Form #18809

merged 16 commits into from
Mar 12, 2021

Commits on Mar 11, 2021

  1. [not verified] First pass add width selector to Button

    @stacimc
    stacimc committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    bbcda00 View commit details
    Browse the repository at this point in the history

  2. [not verified] Add button width on frontend

    @stacimc
    stacimc committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    a85b09b View commit details
    Browse the repository at this point in the history

  3. [not verified] Override alignment CSS to preserve custom widths

    @stacimc
    stacimc committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    2d64eef View commit details
    Browse the repository at this point in the history

  4. [not verified] Fix button width in contact form when alignment selected

    @stacimc
    stacimc committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    daefd84 View commit details
    Browse the repository at this point in the history

  5. [not verified] Load styles for frontend

    @stacimc
    stacimc committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    99085c4 View commit details
    Browse the repository at this point in the history

  6. [not verified] Add non-percentage width controls and disallow percent… 

    …age width when floated

Taking code from #18872

This adds in an additional width control for setting custom width by %/px/em,
and disables the preset width options and custom % options if a left or
right alignment has been selected on the button (to circumvent the issues
with percentage width on floating divs).
    @stacimc
    stacimc committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    c39d163 View commit details
    Browse the repository at this point in the history

  7. [not verified] Persist button width on save

    @stacimc
    stacimc committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    a9519d4 View commit details
    Browse the repository at this point in the history

  8. [not verified] Add button width to Subscriptions form

    @stacimc
    stacimc committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    551b9f9 View commit details
    Browse the repository at this point in the history

  9. [not verified] Remove 100% width on contact form button

    @stacimc
    stacimc committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    ab7cf89 View commit details
    Browse the repository at this point in the history

  10. [not verified] Add maximum width to contact form button

    @stacimc
    stacimc committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    6c07198 View commit details
    Browse the repository at this point in the history

  11. [not verified] Account for margins in width of Subscription form button

    @stacimc
    stacimc committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    373ab17 View commit details
    Browse the repository at this point in the history

  12. [not verified] Update the unit when a percent width preset is selected 

    The unit does not update automatically because updating the value
prop does not cause the onChange event to fire on the UnitControl.
We get around this by keeping track of the unit at the parent
level until this bug can be fixed.
    @stacimc
    stacimc committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    987d39d View commit details
    Browse the repository at this point in the history

  13. [not verified] Subscription form buttons on new line adhere to max width

    @stacimc
    stacimc committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    27e0c77 View commit details
    Browse the repository at this point in the history

  14. [not verified] Reset unit as well as width when button is floated

    @stacimc
    stacimc committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    0d68706 View commit details
    Browse the repository at this point in the history

  15. [not verified] Set max to 100 when width contains %

    @stacimc
    stacimc committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    50e06ba View commit details
    Browse the repository at this point in the history

  16. [not verified] Add changelog.

    @jeherve @stacimc
    jeherve authored and stacimc committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    7371241 View commit details
    Browse the repository at this point in the history