Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions: Add unit tests and fixtures to validate block content parsing #18993

Merged
merged 13 commits into from
Mar 19, 2021

Commits on Mar 15, 2021

  1. Configuration menu
    Copy the full SHA
    96a23a0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    faff64c View commit details
    Browse the repository at this point in the history
  3. Extricating inspector controls children into an external component a…

    …nd adding initial control tests.
    ramonjd committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    763414d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5e23778 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c559af2 View commit details
    Browse the repository at this point in the history
  6. [not verified] Naming the anonymous control function to SubscriptionC…

    …ontrols
    
    Adding mocks for apiFetch in the edit tests
    Using zero values for default input[type=number] fields to receive more reliable userEvent.type results
    ramonjd committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    17dee34 View commit details
    Browse the repository at this point in the history
  7. [not verified] deprecation v1 migrated from the subscribeButton attri…

    …bute to submitButtonText.
    
    To determine whether deprecation v1 is eligible we need to check for both the old property subscribeButton and its value since only checking for empty matches empty/default on other versions.
    
    See: #18993#issuecomment-793490858
    ramonjd committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    fd89a30 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    aab4d70 View commit details
    Browse the repository at this point in the history
  9. [not verified] Add changelog

    ramonjd committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    195c865 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b072072 View commit details
    Browse the repository at this point in the history
  11. [not verified] # This is a combination of 3 commits.

     Bring all deprecations and fixtures into line
    aaronrobertshaw authored and ramonjd committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    1a4d8ef View commit details
    Browse the repository at this point in the history
  12. [not verified] Remove unused dependency

    Clearing some controls before modifying values
    ramonjd committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    58cdf87 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. [not verified] We need to mock the button width control component tem…

    …porarily to avoid type/import errors that should be fixed when we update the wordpress monorepo
    ramonjd committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    affc10a View commit details
    Browse the repository at this point in the history