Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gif: Add unit tests and fixtures to validate block content parsing #19019

Closed
wants to merge 2 commits into from

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Mar 4, 2021

Fixes #

Changes proposed in this Pull Request:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

cd projects/plugins/jetpack && yarn fixtures:test extensions/blocks/gif/test

Proposed changelog entry for your changes:

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello ramonjd! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D58071-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@ramonjd ramonjd added [Block] GIF Unit Tests [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Mar 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Include a changelog entry for any meaningful change.
  • ✅ Specify whether this PR includes any changes to data or privacy.

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


If you are an automattician, once your PR is ready for review add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.undefined


jetpack plugin:

  • Next scheduled release: April 6, 2021.
  • Scheduled code freeze: March 29, 2021

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Mar 4, 2021
@ramonjd ramonjd changed the title Adding fixtures Gif: Add unit tests and fixtures to validate block content parsing Mar 4, 2021
@ramonjd ramonjd force-pushed the add/jetpack-gif-block-tests branch from 903a7c8 to 311441f Compare March 7, 2021 22:35
@ramonjd
Copy link
Member Author

ramonjd commented Mar 8, 2021

This component needs refactoring before we can achieve proper test coverage.

Context: p1615166752126300-slack-CS0SC36SX

@ramonjd ramonjd closed this Mar 8, 2021
@ramonjd ramonjd self-assigned this Mar 8, 2021
@ramonjd ramonjd added [Closed] Won't Fix wontfix. This issue will not be addressed. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Mar 8, 2021
@jeherve jeherve deleted the add/jetpack-gif-block-tests branch May 26, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] GIF [Closed] Won't Fix wontfix. This issue will not be addressed. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files Unit Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants