Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: automatically select product result format for sites with WooCommerce active #19065

Merged
merged 6 commits into from
Mar 11, 2021

Conversation

bluefuton
Copy link
Contributor

@bluefuton bluefuton commented Mar 8, 2021

Changes proposed in this Pull Request:

For users setting up Jetpack Search, the default result format is 'expanded'.

This PR changes the default for sites with Woo installed and active. Those sites will use the new 'product' result format instead.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Apply this patch to your Jetpack site before purchasing Jetpack Search.
  • Install the WooCommerce plugin on your site.
  • Purchase the Jetpack Search subscription for your site.
  • Perform a search and ensure that you are shown the 'product' result format.
  • Check that Jetpack Search setup in the Customizer shows the 'product' result format as the current selection.

Screen Shot 2021-03-09 at 15 25 11

Repeat the above steps on a new site without installing WooCommerce. The result format should be 'expanded' (the default).

Proposed changelog entry for your changes:

  • Search: during setup, automatically use the product result format for sites with WooCommerce active.

@bluefuton bluefuton self-assigned this Mar 8, 2021
@bluefuton bluefuton requested a review from a team as a code owner March 8, 2021 03:24
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello bluefuton! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D58237-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Mar 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


If you are an automattician, once your PR is ready for review add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.undefined


jetpack plugin:

  • Next scheduled release: April 6, 2021.
  • Scheduled code freeze: March 29, 2021

jsnmoon
jsnmoon previously approved these changes Mar 9, 2021
Copy link
Member

@jsnmoon jsnmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected on Jetpack sites with/out WooCommerce installed. Also tested on an Atomic site with WooCommerce installed.

@jsnmoon jsnmoon added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Team Review labels Mar 9, 2021
@jeherve jeherve added this to the 9.6 milestone Mar 10, 2021
jeherve
jeherve previously approved these changes Mar 10, 2021
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well for me. 👍

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Mar 10, 2021
@bluefuton
Copy link
Contributor Author

Thanks @jeherve! Seems to be stuck on a couple of the required checks again - any way to resolve these? I've tried re-running the jobs:

  • Build / Build all projects (pull_request) Skipped
  • Linting / Changelogger use (pull_request) Failing after 14s — Changelogger use

@bluefuton
Copy link
Contributor Author

Shipped to wpcom in r222520-wpcom. 🚢

@jeherve jeherve dismissed stale reviews from jsnmoon and themself via ac37c74 March 11, 2021 12:15
@jeherve
Copy link
Member

jeherve commented Mar 11, 2021

Seems to be stuck on a couple of the required checks again - any way to resolve these?

Yes, we've just enabled this new changelog requirement. I've added it for you in ac37c74, it should be good to merge now.

For more info on the changelogger changes, see p1HpG7-bqa-p2

jeherve
jeherve previously approved these changes Mar 11, 2021
@bluefuton
Copy link
Contributor Author

Thanks for the info on changelog changes @jeherve!

I've just corrected a typo in the changelog message and the PR needs another 🆗 . @jsnmoon are you able to do the honours?

@bluefuton bluefuton merged commit b659820 into master Mar 11, 2021
@bluefuton bluefuton deleted the add/search-set-woo-result-format branch March 11, 2021 23:00
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 11, 2021
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D58237-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@jeherve
Copy link
Member

jeherve commented Mar 12, 2021

I've just corrected a typo in the changelog message

Oops, sorry about that! 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Search For all things related to Search [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants