-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search: automatically select product result format for sites with WooCommerce active #19065
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
projects/plugins/jetpack/modules/search/class-jetpack-instant-search.php
Show resolved
Hide resolved
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 If you are an automattician, once your PR is ready for review add the "[Status] Needs Team review" label and ask someone from your team review the code. jetpack plugin:
|
6c00d98
to
67cdd7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected on Jetpack sites with/out WooCommerce installed. Also tested on an Atomic site with WooCommerce installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well for me. 👍
Thanks @jeherve! Seems to be stuck on a couple of the required checks again - any way to resolve these? I've tried re-running the jobs:
|
Shipped to wpcom in r222520-wpcom. 🚢 |
Yes, we've just enabled this new changelog requirement. I've added it for you in ac37c74, it should be good to merge now. For more info on the changelogger changes, see p1HpG7-bqa-p2 |
Great news! One last step: head over to your WordPress.com diff, D58237-code, and commit it. Thank you! |
Oops, sorry about that! 🤦♂️ |
Changes proposed in this Pull Request:
For users setting up Jetpack Search, the default result format is 'expanded'.
This PR changes the default for sites with Woo installed and active. Those sites will use the new 'product' result format instead.
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Repeat the above steps on a new site without installing WooCommerce. The result format should be 'expanded' (the default).
Proposed changelog entry for your changes: