Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gif block: refactor and add test coverage #19066

Merged
merged 9 commits into from
Mar 15, 2021
Merged

Gif block: refactor and add test coverage #19066

merged 9 commits into from
Mar 15, 2021

Commits on Mar 11, 2021

  1. Initial commit

    @ramonjd
    ramonjd committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    08aea4d View commit details
    Browse the repository at this point in the history

  2. Focusing forward ref input field

    @ramonjd
    ramonjd committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    37d3e9e View commit details
    Browse the repository at this point in the history

  3. Added tests

    @ramonjd
    ramonjd committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    2a9939c View commit details
    Browse the repository at this point in the history

  4. Added @testing-library/react-hooks library to unit test custom hooks 

     Importing regenerator runtime to polyfill transpiled generator functions for react hooks testing library
 Added custom hook to fetch api data
 Added tests for custom hook and updated tests for edit.js
    @ramonjd
    ramonjd committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    c0717d1 View commit details
    Browse the repository at this point in the history

  5. revert css change as it would be a UI regression

    @ramonjd
    ramonjd committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    50ff6af View commit details
    Browse the repository at this point in the history

  6. Removing previous version (kept it for reference while developing)

    @ramonjd
    ramonjd committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    1275a76 View commit details
    Browse the repository at this point in the history

  7. Add changelog

    @ramonjd
    ramonjd committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    31a6058 View commit details
    Browse the repository at this point in the history

  8. Here we are extracting getSelectedGiphyAttributes to utils. getSelect… 

    …edGiphyAttributes is not referencing any props or state so we can use it in the useEffect hook and not reference it.
    @ramonjd
    ramonjd committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    4509013 View commit details
    Browse the repository at this point in the history

  9. Using a regex to capture known giphy paths and extract the id. This i… 

    …s a little stricter than testing for the index of the domain.
    @ramonjd
    ramonjd committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    575a94e View commit details
    Browse the repository at this point in the history