Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jetpack extension tests to work with updated @wordpress dependencies #20315

Conversation

glendaviesnz
Copy link
Contributor

Changes proposed in this Pull Request:

  • Changes to some Jetpack block test expectations to work with the newer Gutenberg @WordPress dependencies

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Check our PR and run pnpm install
  • Run pnpm test-extensions in the projects/plugins/jetpack dir and make sure all pass

@glendaviesnz glendaviesnz added [Type] Janitorial [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jul 8, 2021
@glendaviesnz glendaviesnz requested review from anomiex and a team July 8, 2021 23:09
@glendaviesnz glendaviesnz self-assigned this Jul 8, 2021
@renovate renovate bot closed this Jul 8, 2021
@renovate renovate bot deleted the renovate/wordpress-monorepo-fix-extension-tests branch July 8, 2021 23:10
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


🔴 Action required: Please add missing changelog entries for the following projects: projects/packages/connection-ui, projects/plugins/backup, projects/plugins/jetpack

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Backup plugin:

  • Next scheduled release: August 3, 2021.
  • Scheduled code freeze: July 26, 2021.

Jetpack plugin:

  • Next scheduled release: July 20, 2021.
  • Scheduled code freeze: July 15, 2021.

@github-actions github-actions bot added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jul 8, 2021
@glendaviesnz
Copy link
Contributor Author

glendaviesnz commented Jul 8, 2021

@anomiex this fixes all the extension tests on #19328 - but the renovate bot automatically closed it for some reason. Should I just push these changes direct to #19328? or is there some other way to handle changes to those renovate PRs?

@anomiex
Copy link
Contributor

anomiex commented Jul 9, 2021

I think renovate "owns" any branch that begins with "renovate/". Since it doesn't want to use this name for anything, it closes it.

You can either update #19328 directly or resubmit this with a different branch name that doesn't start with "renovate/".

@glendaviesnz
Copy link
Contributor Author

glendaviesnz commented Jul 11, 2021

Re-opened at #20326 with a non renovate branch name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Ad [Block] Button [Block] Calendly [Block] Gathering Tweetstorms [Block] Latest Instagram Posts [Block] Payment Button aka Recurring Payments [Block] Related Posts [Block] Slideshow [Block] Subscriptions [Package] Connection UI This package no longer exists in the monorepo. [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants