-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jetpack extension tests to work with update to @wordpress dependencies #20326
Merged
glendaviesnz
merged 16 commits into
renovate/wordpress-monorepo
from
fix/extension-tests-for-updated-dependencies
Jul 28, 2021
Merged
Update jetpack extension tests to work with update to @wordpress dependencies #20326
glendaviesnz
merged 16 commits into
renovate/wordpress-monorepo
from
fix/extension-tests-for-updated-dependencies
Jul 28, 2021
Commits on Jul 27, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3bddc40 - Browse repository at this point
Copy the full SHA 3bddc40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91e11c8 - Browse repository at this point
Copy the full SHA 91e11c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 701f3cb - Browse repository at this point
Copy the full SHA 701f3cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ed3b10 - Browse repository at this point
Copy the full SHA 0ed3b10View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7767a4 - Browse repository at this point
Copy the full SHA c7767a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c911b3 - Browse repository at this point
Copy the full SHA 0c911b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a321a1 - Browse repository at this point
Copy the full SHA 7a321a1View commit details -
Provide
isRTL
as an export in thei18n-to-php.js
webpack extensionThis extension is used in place of all `@wordpress/i18n` imports throughout the js codebase. Relatively recently, the `i18n` package stated to export an `isRTL` function, and a lot of consumers use it. Since in Jetpack this package is replaced by this extension - that doesn't export `isRTL` - they were then breaking the build.
Configuration menu - View commit details
-
Copy full SHA for 147524f - Browse repository at this point
Copy the full SHA 147524fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 964f143 - Browse repository at this point
Copy the full SHA 964f143View commit details -
Fix remaining issue in jetpack js build
* Add JSDOM to mock document for emotion library * Exclude extensions/shared/i18n-to-php from its own webpack module remapping so some methods from real package can be imported and re-exported * Fix mapping to dependency-extraction-webpack-plugin util file
Configuration menu - View commit details
-
Copy full SHA for 1dcdde9 - Browse repository at this point
Copy the full SHA 1dcdde9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d73fe8 - Browse repository at this point
Copy the full SHA 7d73fe8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e58e10 - Browse repository at this point
Copy the full SHA 0e58e10View commit details -
Update react to match what @wordpress/* wants
Otherwise we get hundreds of "Invalid hook call" errors.
Configuration menu - View commit details
-
Copy full SHA for cd93eb0 - Browse repository at this point
Copy the full SHA cd93eb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce15092 - Browse repository at this point
Copy the full SHA ce15092View commit details
Commits on Jul 28, 2021
-
Update "validate-es5" to "validate-es9"
Babel does less transpilation now that @wordpress/browserslist-config dropped IE11. ES9 is the minimum version that passes now. Longer term we should replace that check with something better. See p9dueE-3fG-p2 for details.
Configuration menu - View commit details
-
Copy full SHA for e34a689 - Browse repository at this point
Copy the full SHA e34a689View commit details -
Configuration menu - View commit details
-
Copy full SHA for 949882c - Browse repository at this point
Copy the full SHA 949882cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.