Subscription Block: Add success message #21273

amustaque97 · 2021-10-02T22:07:10Z

Fixes #21187

Changes proposed in this Pull Request:

Updated projects/plugins/jetpack/extensions/blocks/subscriptions to support teaxtarea for success_message in the widget setttings.
Updated projects/plugins/jetpack/modules/subscriptions/views.php to support success_message when passed as an attribute to the shortcode.
Updated test cases of subscription form extension

Jetpack product discussion NA

Does this pull request to change what data or activity we track or use? NA

Testing instructions:

Checkout to the PR branch
Build subscription extension
Enable jetpack subscription under discussion tab of jetpack settings
Go to appearance -> customize -> widgets -> footer#1 -> add a legacy widget subscription block (if it not already transformed to subscription block and then transform it to subscription block)
Select subscription block and click on show more settings and scroll down
Edit success message and publish it.
Open the site in incognito mode and then enter an email address
Verify success message.

Screenrecording https://youtu.be/Z5cSgh5neQA

…ption-widget-transform

In this commit, I have updated all the files of subscription block extension I have also updated the modules views.php file to support success_message as a shortcode attribute.

github-actions · 2021-10-02T22:08:22Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
⚠️ All commits were linted before commit.
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Jetpack plugin:

Next scheduled release: January 11, 2022.
Scheduled code freeze: January 3, 2022.

sdixon194 · 2021-10-04T14:45:14Z

Thanks for the contribution @amustaque97 ! Is this PR still in progress or ready for review?

amustaque97 · 2021-10-04T15:11:07Z

Thanks for the contribution @amustaque97 ! Is this PR still in progress or ready for review?

It is ready for review

sdixon194

This works for me! I have a few in line comments that I think we can tighten up. I'm also not an expert on block or react, so if someone else would like to take a look to make sure I'm not missing anything, that'd be appreciated too!

projects/plugins/jetpack/extensions/blocks/subscriptions/controls.js

projects/plugins/jetpack/extensions/blocks/subscriptions/attributes.js

projects/plugins/jetpack/extensions/blocks/subscriptions/save.js

projects/plugins/jetpack/extensions/blocks/subscriptions/attributes.js

jeherve

Nice work! You'll now want to update the tests for the block to reflect your changes. You can check the projects/plugins/jetpack/extensions/blocks/subscriptions/test/ to find out more, and run cd projects/plugins/jetpack && pnpm test-extensions to run those tests locally.

amustaque97 · 2021-10-12T17:26:59Z

@jeherve, Thank you for the appreciation 🙌 and apologies for the delay 😞. I have fixed all the test cases. Please have a look again. All test cases are passing 😄
cc @sdixon194

jeherve · 2021-10-14T10:59:19Z

Thank you. Could you run git merge origin/master in your branch one more time, after pulling the latest version of master in your fork?

amustaque97 · 2021-10-14T11:45:25Z

Thank you. Could you run git merge origin/master in your branch one more time, after pulling the latest version of master in your fork?

Took a merge from the master branch. Test cases are passing.

Changes addressed

…ock-success-message

projects/plugins/jetpack/extensions/blocks/subscriptions/deprecated/v6/save.js

...ts/plugins/jetpack/extensions/blocks/subscriptions/test/fixtures/jetpack__subscriptions.html

samiff

Looking good @amustaque97 ! just some cleanup in v6/save.js is needed and I would try redoing the fixtures once that is completed 👍

On the sidebar of this PR I think there should be an option to let Jetpack maintainers write to your branch if you don't mind so we don't keep having to ask for a master merge 😉

Co-authored-by: Samiff <samiff@users.noreply.github.com>

…ock-success-message

stale

samiff

Those last changes look good, and the tests are passing from what I see 👍

Master will need to be merged once more to bring this up to date.

…ock-success-message

amustaque97 · 2021-12-07T18:29:15Z

Thank you @jeherve and @samiff for helping me with this. I can see this PR took long than expected, more than 2 months to be exact 😅 . Thanks once again for helping me out with this and patiently reviewing my every single commit and multiple code reviews. ❤️

Please consider/ping me in other issues/PR related to deprecation implementation. Would love to get involved. 🚀

samiff · 2021-12-07T20:49:37Z

Thanks for working on this @amustaque97 🎉 This change will ship out in Jetpack version 10.5 which is scheduled to release on: 2022-01-11

Internal: D71163-code marked for 10.5 release (sync with wpcom release)
Edit: r236587-wpcom

* master: (24 commits) Replace base styles with component driven approach (#21938) Release Unreleased GH Actions, JS and Composer Packages (#22041) Have eslint and phpcs ignore jetpack_vendor (#22056) Update PHP 7.4 to 8.0 in our tools (#22046) Connection: Handle package versions on site registration (#22025) Backup plugin: Add the jetpack-identity-crisis package to composer.json (#22036) IDC UI: update the default text in the migrate card (#22033) Doc PHPCS updates (#22042) docker: Fix mu-plugins/fix-monorepo-plugins-url.php (#22044) E2E search plan data fixture (#22039) Composer Packages: change the package type to jetpack-library (#21934) Subscription Block: Add success message (#21273) My Jetpack: do not ship scss and jsx files in production build. (#22032) Notes: Remove old code (#22026) SSO: Add filters for error text (#22004) Backport 10.4 Changelog (#22034) Releases: start 10.5-a.2 cycle (#22031) Releases: prepare changelogs for Jetpack version 10.5-a.1 (#22030) Monorepo now uses Composer 2.1 (#22028) Notifications: PHPCS (#22017) ...

jeherve · 2022-01-03T10:06:47Z

Follow-up: #22193 seems to highlight an issue on WordPress.com Simple sites.

arcangelini and others added 4 commits September 28, 2021 15:04

[not verified] Blog Subscription Widget: Added transform to block

db39b4a

[not verified] Remove widget from Legacy block

bc9c3a9

Merge remote-tracking branch 'origin/master' into update/blog-subscri…

c55b32d

…ption-widget-transform

Subscription Block: Implement success message for subscription block.

6d5a025

In this commit, I have updated all the files of subscription block extension I have also updated the modules views.php file to support success_message as a shortcode attribute.

matticbot added the Touches WP.com Files label Oct 2, 2021

github-actions bot added [Block] Subscriptions [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. labels Oct 2, 2021

github-actions bot added the OSS Citizen This Pull Request was opened by an Open Source contributor. label Oct 2, 2021

Merge branch 'master' into add/subscription-block-success-message

9f3d377

sdixon194 added the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Oct 4, 2021

amustaque97 mentioned this pull request Oct 6, 2021

Podcast Player: Increase the number of episodes shown #21291

Open

sdixon194 previously requested changes Oct 6, 2021

View reviewed changes

projects/plugins/jetpack/extensions/blocks/subscriptions/controls.js Outdated Show resolved Hide resolved

projects/plugins/jetpack/extensions/blocks/subscriptions/controls.js Show resolved Hide resolved

sdixon194 added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Oct 6, 2021

Added label and wrapped string with i18n function

9025896

amustaque97 commented Oct 7, 2021

View reviewed changes

projects/plugins/jetpack/extensions/blocks/subscriptions/attributes.js Show resolved Hide resolved

fixing linting error for successMessage default value in attribute.js

ab25c21

jeherve requested changes Oct 7, 2021

View reviewed changes

projects/plugins/jetpack/extensions/blocks/subscriptions/save.js Show resolved Hide resolved

projects/plugins/jetpack/extensions/blocks/subscriptions/attributes.js Show resolved Hide resolved

jeherve previously requested changes Oct 8, 2021

View reviewed changes

jeherve assigned jeherve and amustaque97 Oct 21, 2021

Merge remote-tracking branch 'origin/master' into add/subscription-bl…

6df7bed

…ock-success-message

samiff reviewed Dec 7, 2021

View reviewed changes

projects/plugins/jetpack/extensions/blocks/subscriptions/deprecated/v6/save.js Outdated Show resolved Hide resolved

samiff reviewed Dec 7, 2021

View reviewed changes

projects/plugins/jetpack/extensions/blocks/subscriptions/deprecated/v6/save.js Outdated Show resolved Hide resolved

samiff reviewed Dec 7, 2021

View reviewed changes

...ts/plugins/jetpack/extensions/blocks/subscriptions/test/fixtures/jetpack__subscriptions.html Show resolved Hide resolved

samiff suggested changes Dec 7, 2021

View reviewed changes

amustaque97 and others added 3 commits December 7, 2021 08:54

Update import attributes in deprecation v6 save.js

57b705a

Co-authored-by: Samiff <samiff@users.noreply.github.com>

fix save.js in v6

8ac343e

Merge remote-tracking branch 'origin/master' into add/subscription-bl…

21e64a9

…ock-success-message

samiff self-requested a review December 7, 2021 18:10

samiff approved these changes Dec 7, 2021

View reviewed changes

Merge remote-tracking branch 'origin/master' into add/subscription-bl…

5710093

…ock-success-message

samiff mentioned this pull request Dec 7, 2021

DNM: fusion for #21273 #22037

Closed

samiff added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Dec 7, 2021

samiff enabled auto-merge (squash) December 7, 2021 18:58

samiff self-requested a review December 7, 2021 18:59

samiff approved these changes Dec 7, 2021

View reviewed changes

samiff merged commit c7071a6 into Automattic:master Dec 7, 2021

github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 7, 2021

amustaque97 mentioned this pull request Dec 14, 2021

Feature Request: Customized Donation Block Receipt #22051

Open

amustaque97 deleted the add/subscription-block-success-message branch January 1, 2022 19:51

jeherve mentioned this pull request Jan 3, 2022

Subscription Form block: Success message text does not update #22193

Closed

samiff added [Status] Needs Testing We need to add this change to the testing call for this month's release and removed [Status] Needs Testing We need to add this change to the testing call for this month's release labels Jan 4, 2022

ivan-ottinger mentioned this pull request Apr 7, 2022

[Bug]: Subscribe pattern broken by default Automattic/wp-calypso#62562

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Subscription Block: Add success message #21273

Subscription Block: Add success message #21273

amustaque97 commented Oct 2, 2021 •

edited

Loading

github-actions bot commented Oct 2, 2021 •

edited

Loading

sdixon194 commented Oct 4, 2021

amustaque97 commented Oct 4, 2021

sdixon194 left a comment

jeherve left a comment

amustaque97 commented Oct 12, 2021 •

edited

Loading

jeherve commented Oct 14, 2021

amustaque97 commented Oct 14, 2021 •

edited

Loading

samiff left a comment

samiff left a comment

amustaque97 commented Dec 7, 2021

samiff commented Dec 7, 2021 •

edited

Loading

jeherve commented Jan 3, 2022

Subscription Block: Add success message #21273

Subscription Block: Add success message #21273

Conversation

amustaque97 commented Oct 2, 2021 • edited Loading

Changes proposed in this Pull Request:

Jetpack product discussion NA

Does this pull request to change what data or activity we track or use? NA

Testing instructions:

Screenrecording https://youtu.be/Z5cSgh5neQA

github-actions bot commented Oct 2, 2021 • edited Loading

sdixon194 commented Oct 4, 2021

amustaque97 commented Oct 4, 2021

sdixon194 left a comment

Choose a reason for hiding this comment

jeherve left a comment

Choose a reason for hiding this comment

amustaque97 commented Oct 12, 2021 • edited Loading

jeherve commented Oct 14, 2021

amustaque97 commented Oct 14, 2021 • edited Loading

samiff left a comment

Choose a reason for hiding this comment

samiff left a comment

Choose a reason for hiding this comment

amustaque97 commented Dec 7, 2021

samiff commented Dec 7, 2021 • edited Loading

jeherve commented Jan 3, 2022

amustaque97 commented Oct 2, 2021 •

edited

Loading

github-actions bot commented Oct 2, 2021 •

edited

Loading

amustaque97 commented Oct 12, 2021 •

edited

Loading

amustaque97 commented Oct 14, 2021 •

edited

Loading

samiff commented Dec 7, 2021 •

edited

Loading