Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Add tools/docker/data/ssh.keys/README.txt #32588

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Aug 18, 2023

Proposed changes:

The main purpose of this is to exist to work around #31498 absent an upstream fix.

Note every line in the file needs to begin with # or it'll break the container in a different way.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Fixes #31498

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Without any key files in tools/docker/data/ssh.keys/, running jetpack docker up should not have the sftp container exit with the error in the linked issue.
    • Note you may need to docker container rm jetpack_dev_sftp_1 or the like to clean up an old broken version of the sftp container.

The main purpose of this is to exist to work around #31498 absent an
upstream fix.

Note every line in the file needs to being with `#` or it'll break the
container in a different way.
@anomiex anomiex added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal labels Aug 18, 2023
@anomiex anomiex self-assigned this Aug 18, 2023
@anomiex anomiex enabled auto-merge (squash) August 18, 2023 14:53
@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@kraftbj kraftbj self-requested a review August 18, 2023 19:28
@anomiex anomiex merged commit 339b981 into trunk Aug 18, 2023
@anomiex anomiex deleted the fix/docker-sftp-keys branch August 18, 2023 19:31
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Aug 18, 2023
derekblank pushed a commit that referenced this pull request Aug 23, 2023
The main purpose of this is to exist to work around #31498 absent an
upstream fix.

Note every line in the file needs to being with `#` or it'll break the
container in a different way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jetpack Docker: sftp container fails
2 participants