Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNMobile: Ensure playsInline attribute conforms when falling back to core Video block #35981

Merged
merged 3 commits into from
Feb 28, 2024
Merged

RNMobile: Ensure playsInline attribute conforms when falling back to core Video block #35981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee6267f
fix: Rename playsInline to conform to Video block
Feb 27, 2024
1da13c4
docs: Add CHANGELOG entry
Feb 27, 2024
2620cda
Merge branch 'trunk' into rnmobile/ensure-playsinline-setting-confirm…
Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...ects/plugins/jetpack/changelog/rnmobile-ensure-playsinline-setting-confirms-to-core-video
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: other

RNMobile: Ensure playsInline setting always conforms to Video block schema.
9 changes: 8 additions & 1 deletion projects/plugins/jetpack/extensions/blocks/videopress/save.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,14 @@ const VideoPressSave = CoreVideoSave => props => {
* @see https://github.com/WordPress/gutenberg/blob/c5f9bd88125282a0c35f887cc8d835f065893112/packages/editor/src/hooks/generated-class-name.js#L42
* @see https://github.com/Automattic/wp-calypso/pull/30546#issuecomment-463637946
*/
return CoreVideoSave( props );
// Rename `playsinline` to `playsInline` to conform the block schema of core Video block.
const { playsinline: videoPressPlayinline, ...restAttributes } = props.attributes;
const coreVideoAttributes = { ...restAttributes, playsInline: playsinline };

return CoreVideoSave( {
...props,
attributes: coreVideoAttributes,
} );
}

const url = getVideoPressUrl( guid, {
Expand Down
Loading