Google Analytics: display deprecation notices

[sergeymitr]

Proposed changes:

• Display Google Analytics deprecation notice on non-Jetpack admin pages.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/vulcan/issues/315

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Self-hosted

1. Connect Jetpack.
2. Go to "Jetpack -> Settings -> Traffic", find the "Google Analytics" card and purchase a plan.
3. Go back to "Jetpack -> Settings -> Traffic", follow the link to Calypso. Activate GA, enter a measurement ID (e.g. "G-12345").
4. Go to any non-Jetpack admin page, confirm that you see the deprecation notice (see example below), and the link works.
5. Go to Jetpack Dashboard and Jetpack Settings, confirm the notice shows up (see example below), and the link works.
6. Go to "Jetpack -> Settings -> Traffic", find the Google Analytics card, confirm the notice shows up in there (see
   example below), and the link works.
7. Go to "Jetpack -> My Jetpack", confirm the notice shows up and the link works. Confirm the (1) red bubble shows next to "Jetpack" in the sidebar menu.
8. Install/activate the Google Analytics Legacy plugin, confirm all those notices disappear (non-Jeptack pages, Jetpack pages, GA settings card, My Jetpack).
9. Deactivate the plugin, confirm the notice reappears.
10. Disable Google Analytics feature in Calypso, confirm the notice disappears. Enable it back.
11. Click "X" to dismiss the non-Jetpack notice. Refresh the page, confirm it doesn't appear again.

WoA

1. Checkout the PR via Jetpack Beta on a WoA site.
2. Activate Google Analytics, save a measurement ID.
3. Go to your site's /wp-admin/. Check the same pages (non-Jetpack pages, Jetpack pages, GA settings card, My Jetpack), confirm none of the notices show up.

The notice

Non-Jetpack pages:

Jetpack Dashboard and Settings:

Google Analytics settings card:

My Jetpack:

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/ga-deprecation-notice branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack add/ga-deprecation-notice
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for July 2, 2024 (scheduled code freeze on July 1, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Backup plugin:

• Next scheduled release: July 2, 2024.
• Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Boost plugin:

• Next scheduled release: July 2, 2024.
• Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Search plugin:

• Next scheduled release: July 2, 2024.
• Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Social plugin:

• Next scheduled release: July 2, 2024.
• Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Starter Plugin plugin:

• Next scheduled release: July 2, 2024.
• Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Protect plugin:

• Next scheduled release: July 2, 2024.
• Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Videopress plugin:

• Next scheduled release: July 2, 2024.
• Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Migration plugin:

• Next scheduled release: July 2, 2024.
• Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[chrisbliss18]

The design of the notice is in keeping with the standard WP notice, so that works and makes sense.

The notice links to this page, which doesn't have any information on how to keep using Google Analytics on the site. Is this meant as a temp placeholder until an appropriate page can be written, is this page meant to be updated with relevant information, or are there other plans?

As for the text of the notice, I do have a couple of concerns:

1. "no longer be supported" sounds like the feature will work, but the user can no longer get technical support for it.
2. "See how to keep your site intact" is a bit odd as it suggests that the site might stop functioning.

What do you think of this text?

Jetpack's Google Analytics feature will be removed on August 6, 2024. Read this document for details and how to keep tracking visits with Google Analytics.

[sergeymitr]

Thanks for taking a look @chrisbliss18

The notice links to this page, which doesn't have any information on how to keep using Google Analytics on the site. Is this meant as a temp placeholder until an appropriate page can be written, is this page meant to be updated with relevant information, or are there other plans?

The plan is to add the "Deprecated on self-hosted..." message at the top, with the link to the Legacy plugin.
Similarly to what they did with Custom CSS: https://jetpack.com/support/custom-css/

What do you think of this text?

Looks a lot better, updated in the PR.

[chrisbliss18]

The changes look good. I confirmed the presence and proper styling of the notice in My Jetpack, Jetpack's Dashboard, and the settings page.

I approve the changes. Thanks for the PR. :)

[chrisbliss18]

Re-approving after your trunk merge.