Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate: update label used to flag Search updates #38168

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jul 3, 2024

Proposed changes:

We now prefix our feature labels with [Feature].

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

We now prefix our feature labels with [Feature].
@jeherve jeherve added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Janitorial [Pri] Low [Feature] Search For all things related to Search labels Jul 3, 2024
@jeherve jeherve requested a review from a team July 3, 2024 07:06
@jeherve jeherve self-assigned this Jul 3, 2024
@jeherve jeherve enabled auto-merge (squash) July 3, 2024 07:06
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@@ -105,7 +105,7 @@
'@testing-library/preact',
],
reviewers: [ 'team:jetpack-search' ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this team doesn't seem to exist anymore. I asked at #38133 (comment) whether we should remove this whole config block (lines 94–109) and let these be handled like any other updates instead of being grouped as "Instant Search".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it to Red in 49bf9eb, following #38133 (comment)

@anomiex anomiex requested a review from kangzj July 3, 2024 16:16
@anomiex
Copy link
Contributor

anomiex commented Jul 3, 2024

LGTM if Team Red is fine with it.

@kangzj: What this will do is have Renovate add Team Red as the requested reviewer when it creates a PR like #38133.

@kangzj
Copy link
Contributor

kangzj commented Jul 3, 2024

Hi @anomiex prompt reviews might not be guaranteed but I'm fine with that. Thanks for asking!

@jeherve jeherve merged commit 22e1cb1 into trunk Jul 4, 2024
53 checks passed
@jeherve jeherve deleted the update/renovate-config-search branch July 4, 2024 12:07
@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants