Fixes scrollbar issue if upsell nudge is loaded in sidebar

[candy02058912]

Fixes https://github.com/Automattic/dotcom-forge/issues/7936
The bug details and reproduction video are in the original issue.

Before

Nav.scroll.issue.mp4

After

CleanShot.2024-07-03.at.19.35.41.mp4

Proposed changes:

• Trigger a resize event when the upsell nudge is loaded to make WP aware that the nav sidebar has to be scrollable.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

• Follow the instructions in Fixes scrollbar issue if upsell nudge is loaded in sidebar #38170 (comment) for the environment your testing

What is being fixed with this PR:

• With a Simple Default site
• Go to /wp-admin
• After the upsell nudge shows, the nav bar is still scrollable

Note

Test for WoA and Jetpack sites to make sure nothing is broken due to this PR

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/nav-classic-default-/wp-admin branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack fix/nav-classic-default-/wp-admin
  

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/nav-classic-default-/wp-admin
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

[Addison-Stavlo]

This fixes the issue on my end!

My first thought was why we are applying this fix separately from the jitm code itself, but I think that makes sense considering the mutation observer needs to be in place first.

Aside, Im unsure why but I needed to run the mu-wpcom install script as well to test this even though all the file changes seem to be in the masterbar package. 😕 Either way running both install commands for simple tests well.

[candy02058912]

Aside, Im unsure why but I needed to run the mu-wpcom install script as well to test this even though all the file changes seem to be in the masterbar package.

The one that is actually being used on simple sites when I was testing was the file under fbhepr%2Skers%2Sjcpbz%2Sjc%2Qpbagrag%2Szh%2Qcyhtvaf%2Swrgcnpx%2Qzh%2Qjcpbz%2Qcyhtva%2Sfha%2Siraqbe%2Snhgbznggvp%2Swrgcnpx%2Qznfgreone%2Sfep%2Snqzva%2Qzrah%2Spynff%2Qnqzva%2Qzrah.cuc%3Se%3Q399n5258-og, so it's bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/nav-classic-default-/wp-admin that gives us the relative files from this PR to test.