Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Sync: Fix HPOS checksum support for wc_order_operational_data #38191

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

fgiannar
Copy link
Contributor

@fgiannar fgiannar commented Jul 4, 2024

Sync HPOS checksum for wc_order_operational_data table relies on the order_key and cart_hash checksum text fields.
However, the _cart_hash meta was never added to the corresponding WooCommerce meta whitelist, therefore will not be available when syncing an order via the WooCommerce_HPOS_Orders Sync module.

This PR fixes this bug by adding _cart_hash to Sync's WooCommerce post meta whitelist.

Proposed changes:

  • Automattic\Jetpack\Sync\Modules\WooCommerce: Add _cart_hash to Sync's WooCommerce post meta whitelist.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p9dueE-8ec-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Pre-requisites: A JP connected site with WooCommerce and Jetpack plugins active.

  • Try syncing an order with/without this PR applied
  • Inspect the corresponding wc_order_operational_data table on WPCOM and confirm that with the PR applied the cart_hash column is populated

@fgiannar fgiannar added [Type] Bug When a feature is broken and / or not performing as intended [Status] In Progress labels Jul 4, 2024
@fgiannar fgiannar self-assigned this Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/sync-orders-_cart_hash branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/sync-orders-_cart_hash
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/sync-orders-_cart_hash
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@fgiannar fgiannar requested review from a team and darssen July 4, 2024 07:56
@fgiannar fgiannar added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Status] Needs Team Review and removed [Status] In Progress [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jul 4, 2024
Copy link
Contributor

@darssen darssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@fgiannar fgiannar merged commit 17aa73d into trunk Jul 5, 2024
77 of 78 checks passed
@fgiannar fgiannar deleted the fix/sync-orders-_cart_hash branch July 5, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Sync [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants