-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack AI: Only display "turn list into table" menu item for top level lists #40177
Jetpack AI: Only display "turn list into table" menu item for top level lists #40177
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
disabled = false, | ||
onAskAiAssistant, | ||
onRequestSuggestion, | ||
}: AiAssistantToolbarDropdownContentProps ): ReactElement { | ||
const blockQuickActions = quickActionsList[ blockType ] ?? []; | ||
|
||
const { getBlockParents } = select( 'core/block-editor' ); | ||
const blockParents = getBlockParents( clientId ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other option we can do is to always display the transform option and just find the root list and transform the entire thing every time, regardless of where they click AI Assistant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds interesting, do you think is doable without refactoring too much? Can we explore it? UX wise I think it'd be much more comfortable for the user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of automating the trigger from root of list, but I'll leave it up for your consideration. Otherwise, this worked fine for me!
ec01784
to
eb1fd2d
Compare
Adding missing property to |
…n though the code works?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #40137
Proposed changes:
Other information:
Jetpack product discussion
N/A but this was mentioned in the previous PR.
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Once you've checked out the branch and built Jetpack, you will need to enable the feature via a snippet or similar means:
Once that's done, create a new post and create a list with multiple sub-lists, like so:
Validate: