Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack AI: Requests that use Chrome AI should not cause front-end to show a request has been used #41900

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

mwatson
Copy link
Contributor

@mwatson mwatson commented Feb 19, 2025

Fixes #41899

Proposed changes:

  • Fixes issue where the front end was counting requests to Chrome's AI as counting against their overall request count.
  • This issue only occurred on the front end, so no backend fix is needed

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Setup

  • Set up your Jetpack such that you don't have unlimited AI requests
  • If sandboxing the WPCOM api (not required) you can add this to your 0-sandbox file to fake it:
add_filter( 'jetpack_ai_current_period_requests_count', function() { return 5; } );
add_filter( 'jetpack_ai_all_time_requests_count', function() { return 5; } );
add_filter( 'jetpack_ai_tier_licensed_quantity', function() { return 0; } );
  • Verify that you see the request counter in the Jetpack AI Assistant portion of the sidebar:

Screenshot 2025-02-19 at 5 06 59 PM

  • Make sure you have Chrome AI enabled via the testing instructions in this PR

Recreating / Verifying The Bug

  • Create a new post and add some text in English. Translate into a non-supported language (French or German). The request counter should decrease by one.
  • Undo your change and translate into a language supported by Chrome AI (Spanish, Chinese, Russian). After translating the request counter should also decrease by one.

Testing The Fix

  • Now check out this branch and rebuild/reload.
  • Doing the same steps above, translate some text to French or German and observe that the request counter decreases.
  • Next translate to a language supported by Chrome AI. The counter should no longer decrease.

Copy link
Contributor

github-actions bot commented Feb 19, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the change/jetpack-ai-chrome-fe-request-fix branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack change/jetpack-ai-chrome-fe-request-fix

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Block] AI Assistant [JS Package] AI Client [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA labels Feb 19, 2025
Copy link
Contributor

github-actions bot commented Feb 19, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link

jp-launch-control bot commented Feb 19, 2025

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/extensions/blocks/ai-assistant/edit.js 0/139 (0.00%) 0.00% 1 ❤️‍🩹
projects/plugins/jetpack/extensions/blocks/ai-assistant/extensions/with-ai-extension.tsx 0/173 (0.00%) 0.00% 1 ❤️‍🩹

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@mwatson mwatson added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Feb 19, 2025
… changing when using the extension (original fix only applied to ai assistant)
Copy link
Contributor

@dhasilva dhasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] AI Assistant I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [JS Package] AI Client [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA [Status] Needs Team Review [Type] Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants