Turn off search indexes by default, Closes #412

Automattic · Mar 24, 2015 · f36cf49 · f36cf49
1 parent 12ed155
commit f36cf49
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/History.md b/History.md
@@ -3,8 +3,9 @@
 
 * Upgrade to express 4.x, Closes #537
 * Move `job.process` done callback to the last, Closes #387, Closes #385
-* Document Javascript API to query queue state, Closes #455
 * Standardize signature of `.shutdown()` callback, Closes #454
+* Turn off search indexes by default, Closes #412
+* Document Javascript API to query queue state, Closes #455
 
 
 

diff --git a/Readme.md b/Readme.md
@@ -620,12 +620,12 @@ queue.create('email', {
 }).searchKeys( ['to', 'title'] ).save();
 ```
 
-You may also fully disable search indexes for redis memory optimization:
+Search feature is turned off by default from Kue `>=0.9.0`. Read more about this [here](https://github.com/LearnBoost/kue/issues/412). You should enable search indexes in you need to:
 
 ```javascript
 var kue = require('kue');
 q = kue.createQueue({
-    disableSearch: true
+    disableSearch: false
 });
 ```
 

diff --git a/lib/kue.js b/lib/kue.js
@@ -88,7 +88,7 @@ function Queue( options ) {
     this.promoter = null;
     this.workers = exports.workers;
     this.shuttingDown = false;
-    Job.disableSearch = options.disableSearch;
+    Job.disableSearch = options.disableSearch !== false;
 }
 
 /**

diff --git a/lib/queue/job.js b/lib/queue/job.js
@@ -401,7 +401,6 @@ Job.prototype.delay = function (ms) {
     if(ms > 0) {
         this._delay = ms;
     }
-//    this._state = 'delayed';
     return this;
 };