Team sync changes #23

ashfame · 2023-09-29T13:20:48Z

This PR changes the team sync behavior in following ways:

Don't update slack ghost users upon every message as they are already handled in realtime under team sync
Fix bug in membership change calculation when syncing channels upon boot
Handle channel_archive slack event
Define rooms field under teamsync config for who should be the creator, mods and admins in new rooms created by team sync
Tweak message that gets posted in a new channel to suggest inviting matrixbridge app
Notify admins in admin room for bridge when bridge initialises upon boot, when a slack channel is created/archived/deleted and unlinking of bridge fails upon channel archive/delete event.

Plan to get this deployed:

Review PR (@psrpinto)
Deploy it on staging to test
Deploy on prod

…long with a list of users who should be moderators in these rooms

…msync

- logic for collecting users which are to leave the room was incorrect - additionally, now we just work with matrix user ids for both leaving/joining of new users, as opposed to working with SlackGhost object

…vent" This reverts commit f77f12a. we had to explicitly subscribe a handler to channel_archive event in RTM API

… as well

…s enabled as user_change events are handled in realtime under team sync

psrpinto

Good stuff! Made some suggestions, and also have a couple of questions.

src/TeamSyncer.ts

src/BridgedRoom.ts

src/Main.ts

src/TeamSyncer.ts

Co-authored-by: Paulo Pinto <paulo.pinto@automattic.com>

ashfame · 2023-10-17T15:00:35Z

@psrpinto Thanks for the detailed feedback in this PR, appreciate it! <3

Its ready for you to take another look at it, in addition to your thoughts on the last commit.

psrpinto

Looks good!

Last commit looks good, nothing to add.

README.md

ashfame added 2 commits September 29, 2023 16:35

notify us admins in admin room about a deleted slack channel

caeb355

notify us admins in admin room when bridge boots up

7b831ab

ashfame requested a review from psrpinto September 29, 2023 13:20

ashfame self-assigned this Sep 29, 2023

ashfame added 5 commits October 9, 2023 16:34

add bridged room id to notification message upon slack channel deletion

224fdb8

ensure rooms are created by super admin user, creator is only a mod a…

556b146

…long with a list of users who should be moderators in these rooms

remove super_admin_user field in config and add rooms field under tea…

bdff14a

…msync

change hint message when new slack channel is created

9f3f6c0

fix bug with membership sync logic

c274bee

- logic for collecting users which are to leave the room was incorrect - additionally, now we just work with matrix user ids for both leaving/joining of new users, as opposed to working with SlackGhost object

ashfame force-pushed the team_sync branch from 190c92a to c274bee Compare October 10, 2023 15:05

handle channel_archive event

17505ea

ashfame force-pushed the team_sync branch from adea1df to b73af0c Compare October 10, 2023 15:43

dedupe code from archive/deletion channel handlers

fe1627b

ashfame force-pushed the team_sync branch from b73af0c to fe1627b Compare October 11, 2023 07:10

ashfame added 7 commits October 11, 2023 14:11

account for inconsistent event handling for channel_archive event

f77f12a

subscribe to member_left_channel event

6570485

subscribe to channel_archive event as well

e184ded

Revert "account for inconsistent event handling for channel_archive e…

d902cdd

…vent" This reverts commit f77f12a. we had to explicitly subscribe a handler to channel_archive event in RTM API

fix event name

d2fb55d

notify us when a new bridged room is created upon a new slack channel…

e520141

… as well

disable updating ghost users upon each slack message when team sync i…

e8035fb

…s enabled as user_change events are handled in realtime under team sync

ashfame marked this pull request as ready for review October 13, 2023 11:45

psrpinto reviewed Oct 16, 2023

View reviewed changes

ashfame and others added 7 commits October 17, 2023 12:12

better var name

053c816

move notifyAdmins func to Main

afb7a9d

Update src/TeamSyncer.ts

c087416

Co-authored-by: Paulo Pinto <paulo.pinto@automattic.com>

Update src/TeamSyncer.ts

bf0c565

Co-authored-by: Paulo Pinto <paulo.pinto@automattic.com>

Update src/TeamSyncer.ts

7bee73b

Co-authored-by: Paulo Pinto <paulo.pinto@automattic.com>

Update src/TeamSyncer.ts

c4f22ac

Co-authored-by: Paulo Pinto <paulo.pinto@automattic.com>

improve performance of membership sync at boot

0dfbb4f

ashfame added 5 commits October 17, 2023 18:07

move power levels code a bit above

fb909d7

improve code organisation in createRoomForChannel

fcbe71b

notify us if unlinking fails, so that we can manually act

12c63a0

define new method on fakeDatastore for tests to pass

1db0e5a

log if fails to notify admins, makes integration test pass

e002c3b

ashfame requested a review from psrpinto October 17, 2023 15:00

document team sync modifications in readme

88963fe

psrpinto approved these changes Oct 18, 2023

View reviewed changes

README.md Outdated Show resolved Hide resolved

move readme section

28f6b85

ashfame merged commit 921113c into develop Nov 17, 2023
2 checks passed

ashfame deleted the team_sync branch November 21, 2023 10:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Team sync changes #23

Team sync changes #23

ashfame commented Sep 29, 2023 •

edited

Loading

psrpinto left a comment

ashfame commented Oct 17, 2023

psrpinto left a comment •

edited

Loading

Team sync changes #23

Team sync changes #23

Conversation

ashfame commented Sep 29, 2023 • edited Loading

psrpinto left a comment

Choose a reason for hiding this comment

ashfame commented Oct 17, 2023

psrpinto left a comment • edited Loading

Choose a reason for hiding this comment

ashfame commented Sep 29, 2023 •

edited

Loading

psrpinto left a comment •

edited

Loading