test(query): repro #1698

Automattic · Dec 1, 2017 · 0de9867 · 0de9867
1 parent f46e033
commit 0de9867
Showing 1 changed file with 19 additions and 5 deletions.
diff --git a/test/query.test.js b/test/query.test.js
@@ -547,6 +547,7 @@ describe('Query', function() {
       assert.ok(!threw);
       done();
     });
+
     it('works with overwriting previous object args (1176)', function(done) {
       var q = new Query({}, {}, null, p1.collection);
       assert.doesNotThrow(function() {
@@ -1862,11 +1863,11 @@ describe('Query', function() {
 
       var MyModel = db.model('gh4378', schema);
 
-      assert.throws(function() {
-        MyModel.findOne('');
-      }, /Invalid argument to findOne()/);
-
-      done();
+      MyModel.findOne('', function(error) {
+        assert.ok(error);
+        assert.equal(error.name, 'ObjectParameterError');
+        done();
+      });
     });
 
     it('handles geoWithin with $center and mongoose object (gh-4419)', function(done) {
@@ -2251,6 +2252,19 @@ describe('Query', function() {
       });
     });
 
+    it('with non-object args (gh-1698)', function(done) {
+      var schema = new mongoose.Schema({
+        email: String
+      });
+      var M = db.model('gh1698', schema);
+
+      M.find(42, function(error) {
+        assert.ok(error);
+        assert.equal(error.name, 'ObjectParameterError');
+        done();
+      });
+    });
+
     it('queries with BSON overflow (gh-5812)', function(done) {
       this.timeout(10000);