perf: avoid registering event listeners on subdocuments to reduce mem…

…ory usage Re: #11541
Automattic · Apr 27, 2022 · 1aa4c4e · 1aa4c4e
1 parent 2119e5a
commit 1aa4c4e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 15 deletions.
diff --git a/lib/model.js b/lib/model.js
@@ -3500,6 +3500,7 @@ function _setIsNew(doc, val) {
   const subdocs = doc.$getAllSubdocs();
   for (const subdoc of subdocs) {
     subdoc.$isNew = val;
+    subdoc.$emit('isNew', val);
   }
 }
 

diff --git a/lib/schema/SubdocumentPath.js b/lib/schema/SubdocumentPath.js
@@ -60,25 +60,14 @@ function _createConstructor(schema, baseClass) {
   Subdocument || (Subdocument = require('../types/subdocument'));
 
   const _embedded = function SingleNested(value, path, parent) {
-    const _this = this;
-
     this.$__parent = parent;
     Subdocument.apply(this, arguments);
 
-    this.$session(this.ownerDocument().$session());
-
-    if (parent) {
-      parent.$on('save', function() {
-        _this.emit('save', _this);
-        _this.constructor.emit('save', _this);
-      });
-
-      parent.$on('isNew', function(val) {
-        _this.isNew = val;
-        _this.emit('isNew', val);
-        _this.constructor.emit('isNew', val);
-      });
+    const ownerDocument = this.ownerDocument();
+    if (ownerDocument == null) {
+      return;
     }
+    this.$session(ownerDocument.$session());
   };
 
   schema._preCompile();