fix(types): allow $pull with _id

Fix #12142
Automattic · Aug 3, 2022 · b57efec · b57efec
1 parent 25e4580
commit b57efec
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/test/types/queries.test.ts b/test/types/queries.test.ts
@@ -341,3 +341,16 @@ function gh12091() {
   }
   update.$addToSet.friendsNames = 'Jane Doe';
 }
+
+function gh12142() {
+  const schema = new Schema({ name: String, comments: [{ text: String }] });
+
+  const Test = model('Test', schema);
+
+  Test.updateOne(
+    { _id: new Types.ObjectId() },
+    {
+      $pull: { comments: new Types.ObjectId() }
+    }
+  );
+}
diff --git a/types/index.d.ts b/types/index.d.ts
@@ -457,8 +457,8 @@ declare module 'mongoose' {
     /** @see https://docs.mongodb.com/manual/reference/operator/update-array/ */
     $addToSet?: Mutable<mongodb.SetFields<TSchema>>;
     $pop?: AnyKeys<TSchema> & AnyObject;
-    $pull?: Mutable<mongodb.PullOperator<TSchema>>;
-    $push?: Mutable<mongodb.PushOperator<TSchema>>;
+    $pull?: AnyKeys<TSchema> & AnyObject;
+    $push?: AnyKeys<TSchema> & AnyObject;
     $pullAll?: AnyKeys<TSchema> & AnyObject;
 
     /** @see https://docs.mongodb.com/manual/reference/operator/update-bitwise/ */