Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Model.prototype.deleteOne() return a query, not a promise, to be consistent with Model.prototype.updateOne() #13369

Closed
2 tasks done
vkarpov15 opened this issue May 2, 2023 · 0 comments
Closed
2 tasks done

Make Model.prototype.deleteOne() return a query, not a promise, to be consistent with Model.prototype.updateOne() #13369

vkarpov15 opened this issue May 2, 2023 · 0 comments
Assignees
@IslandRhythms
Labels
backwards-breaking enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature
Milestone
8.0

Comments

@vkarpov15
Copy link
Collaborator

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

Re: #13367, #13223.
@vkarpov15 vkarpov15 added enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature backwards-breaking labels May 2, 2023
@vkarpov15 vkarpov15 added this to the 8.0 milestone May 2, 2023
@vkarpov15 vkarpov15 mentioned this issue May 2, 2023
Merged
vkarpov15 added a commit that referenced this issue Jul 17, 2023
@vkarpov15
Merge branch 'IslandRhythms/gh-13369' of github.com:Automattic/mongoo…
d9fd789 
…se into IslandRhythms/gh-13369
vkarpov15 added a commit that referenced this issue Jul 26, 2023
@vkarpov15
Merge branch '8.0' into IslandRhythms/gh-13369
df6ad8e
vkarpov15 added a commit that referenced this issue Jul 26, 2023
@vkarpov15
BREAKING CHANGE: make model.prototype.deleteOne() return query, not p…
9fbed32 
…romise

Fix #13369
@vkarpov15 vkarpov15 mentioned this issue Jul 26, 2023
Merged
vkarpov15 added a commit that referenced this issue Aug 1, 2023
@vkarpov15
Merge pull request #13660 from Automattic/IslandRhythms/gh-13369
c9a8f16 
BREAKING CHANGE: make model.prototype.deleteOne() return query, not promise
vkarpov15 added a commit that referenced this issue Oct 13, 2023
@vkarpov15
docs: add note about deleteOne() changes re: #13369
f6e5a50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IslandRhythms IslandRhythms

Labels
backwards-breaking enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature
Projects
None yet
Milestone
8.0
Development

No branches or pull requests
2 participants
@vkarpov15 @IslandRhythms