Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate overwrite option to findOneAndUpdate() #13578

Closed
2 tasks done
vkarpov15 opened this issue Jul 4, 2023 · 0 comments · Fixed by #13651
Closed
2 tasks done

Deprecate overwrite option to findOneAndUpdate() #13578

vkarpov15 opened this issue Jul 4, 2023 · 0 comments · Fixed by #13651
Milestone
7.5

Comments

@vkarpov15
Copy link
Collaborator

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

Re: comments on #13572, we should remove this option for next backwards breaking release. It is confusing and inconsistent with the rest of the API.
@vkarpov15 vkarpov15 modified the milestones: 7.4.0, 7.5 Jul 4, 2023
@IslandRhythms IslandRhythms mentioned this issue Jul 24, 2023
Merged
vkarpov15 added a commit that referenced this issue Oct 17, 2023
@vkarpov15
BREAKING CHANGE: remove support for overwrite option setting findOneA…
d14e94d 
…ndUpdate to findOneAndReplace

Re: #13578
vkarpov15 added a commit that referenced this issue Oct 17, 2023
@vkarpov15
refactor: avoid relying on overwrite option for timestamps and castin…
f50d88d 
…g re: #13578
vkarpov15 added a commit that referenced this issue Oct 17, 2023
@vkarpov15
refactor: remove remaining usage of overwrite option
f6ed0eb 
Re: #13578
@vkarpov15 vkarpov15 mentioned this issue Oct 17, 2023
Merged
vkarpov15 added a commit that referenced this issue Oct 20, 2023
@vkarpov15
Merge branch '8.0' into vkarpov15/gh-13578
84ac690
vkarpov15 added a commit that referenced this issue Oct 24, 2023
@vkarpov15
Merge pull request #13989 from Automattic/vkarpov15/gh-13578
f923f6c 
Remove `overwrite` option for `updateOne()`, `findOneAndUpdate()`, etc.
@Hashen110 Hashen110 mentioned this issue Feb 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.5
Development

Successfully merging a pull request may close this issue.

Island rhythms/deprecate overwrite Automattic/mongoose
1 participant
@vkarpov15