fix: fix browser build for Webpack 5 #11717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdelrahmanHafez
approved these changes
Apr 27, 2022
Uzlopak
reviewed
Apr 27, 2022
lib/helpers/isAsyncFunction.js
Outdated
| // for a simple check. | ||
| try { | ||
| asyncFunctionPrototype = Object.getPrototypeOf(async function() {}); | ||
| } catch (err) {} | ||
|
|
||
| module.exports = function isAsyncFunction(v) { |
There was a problem hiding this comment.
we could avoid a potential performance penalty by checking the value of asyncFunctionPrototype only once.
module.exports = asyncFunctionPrototype !== null
? function isAsyncFunction(v) {
return (
typeof v === 'function' &&
Object.getPrototypeOf(v) === asyncFunctionPrototype
);
}
: function () { return false; };
|
What is the actual purpose of the browser build? |
|
@Uzlopak the browser build is supposed to let you run basic schema validation in the browser. The syntax is slightly different: there's no models, you need to define a schema when you create a document. But you can at least define and use Mongoose schemas in the browser. For example: <html>
<head>
<script src="/dist/browser.umd.js"></script>
<script>
const schema = new mongoose.Schema({
name: { type: String, required: true },
quest: { type: String, match: /Holy Grail/i, required: true },
favoriteColor: { type: String, enum: ['Red', 'Blue'], required: true }
});
doc = new mongoose.Document({
name: 'Sir Lancelot of Camelot',
quest: 'To seek the Holy Grail',
favoriteColor: 'Blue'
}, schema);
console.log(doc.validateSync()); // null
doc.set({
name: 'Sir Galahad of Camelot',
quest: 'To seek the Holy Grail',
favoriteColor: 'Yellow'
});
console.log(doc.validateSync()); // ValidationError
</script>
</head>
<body></body>
</html> |
|
I'm genuinely curious if anyone out there is relying on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #11584
Summary
With #11584, there were a few issues that popped up in the browser build:
BufferprocessisAsyncFunction()Examples