perf: improve isBsonType #11846
Merged
perf: improve isBsonType #11846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coyotte508
reviewed
May 28, 2022
| return ( | ||
| typeof obj === 'object' && | ||
| obj !== null && | ||
| obj._bsontype === typename |
There was a problem hiding this comment.
During my previous PR I was wondering whether or not to add an additional check, eg && obj.constructor.name !== 'Object' or && obj.constructor.name.localeCompare(typename, undefined, { sensitivity: 'accent' }) === 0, if someone ever decides to store json data with {_bsonType: xxx} inside
There was a problem hiding this comment.
I dont think that this is necessary. The code change here is functionally equivalent to the previous code. If somebody really starts to create objects with their own _bsonType attribute, than it is their issue. ;)
AbdelrahmanHafez
approved these changes
May 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the PR by @coyotte508 this PR improves the isBsonType function by avoiding the use of the actually heavy get-function.