[⏳] Enhanced auto typed schema. #12122

mohammad0-0ahmad · 2022-07-19T04:26:13Z

Enhance the auto typed schema by covering the effects related to the schema options value.
Issues to be covered or enhance the already solved ones:

TypeScript: timestamps not inferred from schema #12069
Coverage for __v path
Coverage for id virtual path
[help] InferSchemaType, accessing _id field #11967
Optimize ts-benchmark result.
When the _id field is specified in the schema definition, the type of _id field cannot be correctly inferred in the HydratedDocument, perhaps due to incorrect implemention of Require_id #12070
LeanDocument, the third... #11910
TS2589: Type instantiation is excessively deep and possibly infinite #11787
type for $push is incorrect. #12126

mohammad0-0ahmad · 2022-07-21T11:35:21Z

test/types/schema.test.ts

@@ -599,20 +600,6 @@ function gh11997() {
  userSchema.index({ name: 1 }, { weights: { name: 1 } });
 }

-function gh12003() {


This test is incorrect, Auto typed schema will not work if typeKey has been changed in this way, because it will be "type" and will not reflect the correct type of the actual value.
@Uzlopak @vkarpov15 do you have any thoughts?

I don't think we can support this approach to supply schema options with auto typed schema.
It will work just if the end user use "const" assertion and not use predefined type, then the type will reflect the actual value.

… timestamps: true but parent schema does not Fix Automattic#12119

…ticgh-12119 fix(timestamps): set timestamps on child schema when child schema has timestamps: true but parent schema does not

style: change jsdoc headers to have a consistent empty jsdoc line after

style(buffer): change ".split" to "utils.each" for defining methods

docs(fix): fix the link to next page in schema types page

per discussion here: Automattic@f5ee642#commitcomment-79569628

Fix Populating Maps example

Update populate.md

Update compatibility.md

…ing performance degradation Re: Automattic#10349

Fix typo `emaill` to `email`

…this, ...>` causes perf issues Re: Automattic#10349

Bumps [eslint](https://github.com/eslint/eslint) from 8.19.0 to 8.21.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.19.0...v8.21.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

chore(tidelift-alignment): run only in main repository, not in forks

Fix Automattic#12149

… with a bidirectional reference Fix Automattic#12136 Re: 11911

…ticgh-12143 fix(model+query): handle populate with lean transform that deletes `_id`

…criminators Fix Automattic#12150

docs(compatibility): change to use a table

… entire schema optins one generic.

…ests.

Author: Mohammad Ahmad <kurtular.vadisi@gmail.com>

hasezoey · 2023-01-07T14:09:25Z

@mohammad0-0ahmad is this PR still planned on being updated? because it looks rather stale to me - if this should not get a update within ~30 days, i would close it as "stale"

mohammad0-0ahmad · 2023-01-07T14:42:34Z

@mohammad0-0ahmad is this PR still planned on being updated? because it looks rather stale to me - if this should not get a update within ~30 days, i would close it as "stale"

Hello @hasezoey !

Sorry for being inactive for a while.
I don't think as well that I will have time to continue with this one during the next month.
You can close it right now and when I have time to continue with it, then we can reopen it.
@vkarpov15 @Uzlopak might can check this PR and maybe complete it if they have time for that and if it something good to have soon.

Best regards everyone :)

vkarpov15 · 2023-01-14T18:46:10Z

We're going to close this PR for now. We implemented part of this PR in #12731, but ran into some issues like #12871. Given those issues, we want to sort out getting this working for just timestamps option before expanding to other similar tasks. We need to be very cautious with big TypeScript changes, because there's always some obscure issue that pops up.

francescov1 · 2023-01-15T20:39:43Z

@vkarpov15 Was there any progress made on #11787? Or any relevant findings? I tried tackling this about 6 months ago but didn't have any luck, would like to give it another shot

mohammad0-0ahmad force-pushed the schema-options-coverage-auto-typed-schema branch from c1155d8 to 20a9073 Compare July 19, 2022 04:29

mohammad0-0ahmad marked this pull request as draft July 19, 2022 04:37

mohammad0-0ahmad changed the title ~~[:hourglass_flowing_sand:] Enhanced auto typed schema.~~ [⏳] Enhanced auto typed schema. Jul 19, 2022

mohammad0-0ahmad force-pushed the schema-options-coverage-auto-typed-schema branch 3 times, most recently from b728108 to b5fccf6 Compare July 21, 2022 11:31

mohammad0-0ahmad commented Jul 21, 2022

View reviewed changes

mohammad0-0ahmad force-pushed the schema-options-coverage-auto-typed-schema branch from b5fccf6 to d487695 Compare July 21, 2022 23:22

mohammad0-0ahmad mentioned this pull request Jul 24, 2022

TypeScript: timestamps not inferred from schema #12069

Closed

2 tasks

vkarpov15 and others added 13 commits July 25, 2022 21:48

fix(timestamps): set timestamps on child schema when child schema has…

77f671a

… timestamps: true but parent schema does not Fix Automattic#12119

chore: release 6.5.0

f5ee642

Merge pull request Automattic#12151 from Automattic/vkarpov15/Automat…

18d683b

…ticgh-12119 fix(timestamps): set timestamps on child schema when child schema has timestamps: true but parent schema does not

style(buffer): change ".split" to "utils.each" for defining methods

769aa21

docs(fix): fix link to next page in schema types page

af7ef3d

style: change jsdoc headers to have a consistent empty jsdoc line after

63b2209

Merge pull request Automattic#12162 from hasezoey/jsdocHeaderNewLine

7dfe820

style: change jsdoc headers to have a consistent empty jsdoc line after

Merge pull request Automattic#12160 from hasezoey/changeSplitToEach

46b629b

style(buffer): change ".split" to "utils.each" for defining methods

Merge pull request Automattic#12161 from ramesh-km/patch-1

5846eee

docs(fix): fix the link to next page in schema types page

Update compatibility.md

dc43df7

per discussion here: Automattic@f5ee642#commitcomment-79569628

Update populate.md

e5cb559

Fix Populating Maps example

Merge pull request Automattic#12166 from amanfrinati/patch-1

0923e97

Update populate.md

Merge pull request Automattic#12163 from fredkilbourn/patch-1

82dc7b9

Update compatibility.md

mohammad0-0ahmad referenced this pull request in mohammad0-0ahmad-forks/mongoose Jul 28, 2022

Fix one case of the reported issues.

d092fdc

vkarpov15 and others added 4 commits August 1, 2022 10:35

perf(types): revert some changes from Automattic#11650 that were caus…

8020515

…ing performance degradation Re: Automattic#10349

Fix typo emaill to email

d35e2c5

Merge pull request Automattic#12180 from JosueMolinaMorales/patch-1

ce4a4bf

Fix typo `emaill` to `email`

perf(types): make $assertPopulated() not use this, because `Omit<…

77d2c70

…this, ...>` causes perf issues Re: Automattic#10349

mohammad0-0ahmad force-pushed the schema-options-coverage-auto-typed-schema branch 2 times, most recently from 70c6dc5 to 2aa4a62 Compare August 1, 2022 20:09

AbdelrahmanHafez and others added 7 commits August 2, 2022 13:26

Merge pull request Automattic#12197 from hasezoey/disableTideliftOnFork

f50181e

chore(tidelift-alignment): run only in main repository, not in forks

docs(compatibility): change to use a table

d459c8f

fix(types): allow using path with $count

7719569

Fix Automattic#12149

fix(types): avoid baffling circular reference when using PopulatedDoc…

7ed781c

… with a bidirectional reference Fix Automattic#12136 Re: 11911

Merge pull request Automattic#12193 from Automattic/vkarpov15/Automat…

07e36aa

…ticgh-12143 fix(model+query): handle populate with lean transform that deletes `_id`

fix(schema+timestamps): handle insertMany() with timestamps and dis…

25e4580

…criminators Fix Automattic#12150

Merge pull request Automattic#12200 from hasezoey/updateCompat

547680d

docs(compatibility): change to use a table

mohammad0-0ahmad force-pushed the schema-options-coverage-auto-typed-schema branch from 2aa4a62 to 1397189 Compare August 3, 2022 06:46

mohammad0-0ahmad added 4 commits August 3, 2022 10:58

Replace Schema path generic TPathKey with TSchemaOptions to cover the…

139773d

… entire schema optins one generic.

Add extra property to DefaultSchemaOptions and refactor the related t…

0b76d27

…ests.

Refactor comment line

9ad8c6c

Reolve schema type when timestamps option is true.

8577fe9

mohammad0-0ahmad force-pushed the schema-options-coverage-auto-typed-schema branch 6 times, most recently from 611e66e to 120665e Compare August 6, 2022 23:33

ts-benchmark added 6 commits August 7, 2022 01:48

Add new helpers to inferschematype.d.ts file

5a35b07

Author: Mohammad Ahmad <kurtular.vadisi@gmail.com>

coverage for __v path depending on schema options.

a73c87e

Author: Mohammad Ahmad <kurtular.vadisi@gmail.com>

Coverage for id virtual depending on schema options.

846a1de

Author: Mohammad Ahmad <kurtular.vadisi@gmail.com>

Fix Resolve__v

af185d4

Author: Mohammad Ahmad <kurtular.vadisi@gmail.com>

Create and implement Extends to avoid circular ref error.

17ec0ad

Author: Mohammad Ahmad <kurtular.vadisi@gmail.com>

Apply Resolve_id to resolve the type of _id path using schema options

937a491

Author: Mohammad Ahmad <kurtular.vadisi@gmail.com>

mohammad0-0ahmad force-pushed the schema-options-coverage-auto-typed-schema branch from 120665e to 937a491 Compare August 6, 2022 23:51

vkarpov15 closed this Jan 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[⏳] Enhanced auto typed schema. #12122

[⏳] Enhanced auto typed schema. #12122

mohammad0-0ahmad commented Jul 19, 2022 •

edited

Loading

mohammad0-0ahmad Jul 21, 2022

mohammad0-0ahmad Jul 21, 2022 •

edited

Loading

hasezoey commented Jan 7, 2023

mohammad0-0ahmad commented Jan 7, 2023

vkarpov15 commented Jan 14, 2023

francescov1 commented Jan 15, 2023

[⏳] Enhanced auto typed schema. #12122

[⏳] Enhanced auto typed schema. #12122

Conversation

mohammad0-0ahmad commented Jul 19, 2022 • edited Loading

mohammad0-0ahmad Jul 21, 2022

Choose a reason for hiding this comment

mohammad0-0ahmad Jul 21, 2022 • edited Loading

Choose a reason for hiding this comment

hasezoey commented Jan 7, 2023

mohammad0-0ahmad commented Jan 7, 2023

vkarpov15 commented Jan 14, 2023

francescov1 commented Jan 15, 2023

mohammad0-0ahmad commented Jul 19, 2022 •

edited

Loading

mohammad0-0ahmad Jul 21, 2022 •

edited

Loading