fix(discriminator): apply built-in plugins to discriminator schema even if mergeHooks
and mergePlugins
are both false
#12833
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12696
Summary
#12696 correctly points out that if both
mergeHooks
andmergePlugins
are false, then we don't apply built-in plugins. Which is a problem because then we don't call save hooks on subdocs when parent hooks are saved, we don't call validate before save, etc. We use plugins for some of Mongoose's core functionality for dogfooding purposes, so we need to apply our built-in plugins even if the user doesn't want to apply user-defined global plugins to discriminator schemas.Examples