feat(types): add BigInt support
#13114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
changed the title
BitInt supportBigInt support
Uzlopak
changed the title
BigInt supportBigInt support
lpizzinidev
changed the title
BigInt supportBigInt support
lpizzinidev
changed the title
BigInt supportBigInt support
vkarpov15
requested changes
Mar 4, 2023
There was a problem hiding this comment.
I don't agree with the high level direction of this PR. Specifically the decision to create a separate mongoose.Types.BigInt class.
The crux of BigInt support in mongodb@5.1 is support for JavaScript's native BigInt primitive. So Mongoose's treatment of BigInts should be analogous to Mongoose's treatment of numbers, not ObjectIds.
castBigInt()should check fortypeof value === 'bigint', and, if so, returnvalue. Otherwise it should attempt to convert usingBigInt(): https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt- We should add schema-level, collection-level, and global 'useBigInt64' options
|
Closing this since headed in the wrong direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added support for
BigInt.Support for the data type has been introduced in MongoDB driver 5.1.
Closes #13081