-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(schema): add BigInt support, upgrade mongodb -> 5.3.0 #13318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think useBigInt64
still needs to be added to the documentation (likely at Query.prototype.setOptions
?)
also SchemaBigInt
would need to be added to the list in Schema.Types
(which seemingly is also missing UUID, subdocumentpath and documentarray)
Co-authored-by: hasezoey <hasezoey@gmail.com>
@hasezoey this PR adds
|
I'll add |
sorry i wasnt clear, i meant at: Lines 2658 to 2667 in f50a194
|
@hasezoey good point, fixed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
seems like esprima does not like big numbers (the |
Fix #13081
Fix #6936
Summary
Add support for BigInt as a schema type, now that MongoDB driver supports it and all Node.js versions (and Deno) that Mongoose supports have support for BigInt.
Still WIP:
$gt
, etc.)populate()
Examples