fix(QueryCursor): eachAsync parameter of AggregationCursor and QueryCursor #14299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevooKim
changed the title
DevooKim
changed the title
DevooKim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, documentation for QueryCursor.prototype.eachAsync write that it takes a callback as a parameter.
However, with the update to version 7, eachAsync no longer supports callbacks. - Show commits
So, I fix parameters of eachAsync and the migrating guide to 7.
it has two more changes.
AggregationCursor.prototype.next, which was missing the guide.QueryCursor.prototype.next