fix(model): improve update minimizing to only minimize top-level properties in the update #14437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14420
Re: #13782
Summary
The issue in #14420 is that the update to
save()is{ $set: { sub: {} } }, which gets minimized away by #13782. With this PR, we'll only minimize top-level properties of update operators in thesave()update. So in the #14420 case, we'll just minimizesubtonull, but leave the rest of the update. I think this is the most consistent way to handle #14420 without undoing the changes we made in #13782.Examples