Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(document): make document _id type default to unknown instead of any #14541

Merged
merged 2 commits into from
Apr 27, 2024
Merged

types(document): make document _id type default to unknown instead of any #14541

merged 2 commits into from
Apr 27, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14520

Summary

I don't see any reason why IdType can't default to unknown, tests pass and unknown seems more correct. @hasezoey can you please check if this causes any problems for typegoose?

Examples

@vkarpov15 vkarpov15 added this to the 8.4 milestone Apr 26, 2024
hasezoey
hasezoey approved these changes Apr 27, 2024
View reviewed changes
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, also no problems with typegoose.
typegoose already had (more or less always) typed the first parameter of Document to unknown: DocumentType

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Apr 27, 2024
@vkarpov15
Copy link
Collaborator Author

I accidentally pushed fix for #14520 into this branch, so I will merge into 8.4 and then cherry pick 23869fb

@vkarpov15 vkarpov15 changed the base branch from master to 8.4 April 27, 2024 15:23
@vkarpov15 vkarpov15 merged commit cb2e7c1 into 8.4 Apr 27, 2024
37 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-14520 branch April 27, 2024 15:24
@hasezoey
Copy link
Collaborator

I accidentally pushed fix for #14520 into this branch

i was slightly confused, do you mean #14527 and #14444 instead? as #14520 is the issue this PR was made for

@nejidevelops nejidevelops mentioned this pull request Jun 7, 2024
Open
@carltrepanier carltrepanier mentioned this pull request Jun 7, 2024
Merged
@lholmquist lholmquist mentioned this pull request Jun 7, 2024
Closed
@NotZarifGithub NotZarifGithub mentioned this pull request Jun 7, 2024
Open
@PatF3lix PatF3lix mentioned this pull request Jun 7, 2024
Open
This was referenced Jun 7, 2024
Open
Open
@akanchhaS akanchhaS mentioned this pull request Jun 8, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Jun 8, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 8, 2024
Open
@axqqt axqqt mentioned this pull request Jun 8, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request Jun 8, 2024
Open
@mihirhbhatt mihirhbhatt mentioned this pull request Jun 8, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request Jun 8, 2024
Open
@astitva3110 astitva3110 mentioned this pull request Jun 8, 2024
Open
@yunji0387 yunji0387 mentioned this pull request Jun 8, 2024
Merged
@tuanicom tuanicom mentioned this pull request Jun 8, 2024
Merged
@jeanNdagui jeanNdagui mentioned this pull request Jun 9, 2024
Open
@axqqt axqqt mentioned this pull request Jun 22, 2024
Open
@LunarArtemis LunarArtemis mentioned this pull request Jun 22, 2024
Open
@javascript-benchmark javascript-benchmark mentioned this pull request Jun 22, 2024
Open
@lholmquist lholmquist mentioned this pull request Jun 22, 2024
Closed
@Erenkrs Erenkrs mentioned this pull request Jun 22, 2024
Open
@carltrepanier carltrepanier mentioned this pull request Jun 22, 2024
Merged
@nay0101 nay0101 mentioned this pull request Jun 23, 2024
Closed
@yunji0387 yunji0387 mentioned this pull request Jun 23, 2024
Merged
@darshanthind darshanthind mentioned this pull request Jun 23, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 24, 2024
Open
@bukhosi-eugene-mpande bukhosi-eugene-mpande mentioned this pull request Jun 25, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request Jun 25, 2024
Open
@mihirhbhatt mihirhbhatt mentioned this pull request Jun 26, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request Jun 26, 2024
Open
@yunji0387 yunji0387 mentioned this pull request Jun 26, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request Jun 27, 2024
Open
@koushikpuppala koushikpuppala mentioned this pull request Jun 28, 2024
Closed
@akanchhaS akanchhaS mentioned this pull request Jun 28, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 28, 2024
Open
@AllanYuen AllanYuen mentioned this pull request Jun 28, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 29, 2024
Open
@nushydude nushydude mentioned this pull request Jun 29, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 30, 2024
Open
@McDeCoderDude McDeCoderDude mentioned this pull request Jul 1, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request Jul 1, 2024
Open
@shristi9800 shristi9800 mentioned this pull request Jul 1, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jul 2, 2024
Open
@BenedictionL BenedictionL mentioned this pull request Jul 4, 2024
Open
This was referenced Jul 4, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Milestone
8.4
Development

Successfully merging this pull request may close these issues.

Why is the default type of the generic field _id in the class Document of type "any"?
2 participants
@vkarpov15 @hasezoey