-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(query): shallow clone $or, $and if merging onto empty query filter #14580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
sderrow
reviewed
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just a couple thoughts.
Co-authored-by: Sean Derrow <sean.derrow@gmail.com>
Co-authored-by: Sean Derrow <sean.derrow@gmail.com>
2 tasks
vkarpov15
added a commit
that referenced
this pull request
May 24, 2024
This was referenced Jun 5, 2024
This was referenced Jun 22, 2024
This was referenced Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14567
Summary
Currently, when you call
TestModel.find({ $and })
, Mongoose doesn't clone the$and
. ThenQuery.prototype.and()
usespush()
to add onto the$and
array, which modifies the existing$and
array.We already have some logic in place from #12944 that shallow clones $and, $or if they're set, but that only currently kicks in if there's an existing
$and
/$or
. With this PR, we'll do a shallow clone on$and
,$or
if they exist on the user's provided query filter.Examples