Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(model+query): pass TInstanceMethods to QueryWithHelpers so populated docs have methods #14581

Merged
merged 1 commit into from
May 9, 2024
Merged

types(model+query): pass TInstanceMethods to QueryWithHelpers so populated docs have methods #14581

merged 1 commit into from
May 9, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14574
Re: #14441

Summary

Fix for #14441 made it so that, if you chain populate() onto a query, the resulting doc doesn't have instance methods. To fix, we need to make QueryWithHelpers and Query aware of TInstanceMethods; this PR makes sure we pass along TInstanceMethods to queries everywhere

Examples

@vkarpov15 vkarpov15 added this to the 8.3.5 milestone May 9, 2024
@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label May 9, 2024
@vkarpov15 vkarpov15 merged commit 11c754c into master May 9, 2024
5 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-14574 branch May 9, 2024 15:35
@saileshbro saileshbro mentioned this pull request Jun 5, 2024
Merged
@NotZarifGithub NotZarifGithub mentioned this pull request Jun 5, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Jun 5, 2024
Open
@cqumilankorangi cqumilankorangi mentioned this pull request Jun 5, 2024
Open
@bryopsida bryopsida mentioned this pull request Jun 5, 2024
Closed
@lholmquist lholmquist mentioned this pull request Jun 5, 2024
Closed
@saileshbro saileshbro mentioned this pull request Jun 5, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request Jun 5, 2024
Open
@tomlebl tomlebl mentioned this pull request Jun 5, 2024
Closed
@yunji0387 yunji0387 mentioned this pull request Jun 5, 2024
Merged
@axqqt axqqt mentioned this pull request Jun 5, 2024
Open
@yunji0387 yunji0387 mentioned this pull request Jun 5, 2024
Merged
This was referenced Jun 5, 2024
Open
Open
@nejidevelops nejidevelops mentioned this pull request Jun 6, 2024
Open
@tuanicom tuanicom mentioned this pull request Jun 6, 2024
Merged
@MihikaNigam MihikaNigam mentioned this pull request Jun 6, 2024
Open
@carltrepanier carltrepanier mentioned this pull request Jun 6, 2024
Merged
@yunji0387 yunji0387 mentioned this pull request Jun 6, 2024
Merged
@jasbleidysilva jasbleidysilva mentioned this pull request Jun 6, 2024
Open
@yunji0387 yunji0387 mentioned this pull request Jun 6, 2024
Merged
@akanchhaS akanchhaS mentioned this pull request Jun 6, 2024
Open
@malinanu malinanu mentioned this pull request Jun 16, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 16, 2024
Open
@yunji0387 yunji0387 mentioned this pull request Jun 17, 2024
Merged
@ashiq-firoz ashiq-firoz mentioned this pull request Jun 17, 2024
Open
@NehalRajora NehalRajora mentioned this pull request Jun 18, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 20, 2024
Open
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Open
@tarasovkir tarasovkir mentioned this pull request Jun 20, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 21, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Jun 21, 2024
Open
@Pratham-Darji Pratham-Darji mentioned this pull request Jun 21, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Jun 21, 2024
Open
@nhattpn nhattpn mentioned this pull request Jun 21, 2024
Closed
@NotZarifGithub NotZarifGithub mentioned this pull request Jun 21, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Jun 21, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 21, 2024
Open
This was referenced Jun 22, 2024
Open
Open
@MihikaNigam MihikaNigam mentioned this pull request Jun 22, 2024
Open
@nturukunga nturukunga mentioned this pull request Jun 22, 2024
Open
@axqqt axqqt mentioned this pull request Jun 22, 2024
Open
@LunarArtemis LunarArtemis mentioned this pull request Jun 22, 2024
Open
@javascript-benchmark javascript-benchmark mentioned this pull request Jun 22, 2024
Open
@lholmquist lholmquist mentioned this pull request Jun 22, 2024
Closed
@Erenkrs Erenkrs mentioned this pull request Jun 22, 2024
Open
@nay0101 nay0101 mentioned this pull request Jun 23, 2024
Closed
@yunji0387 yunji0387 mentioned this pull request Jun 23, 2024
Merged
@darshanthind darshanthind mentioned this pull request Jun 23, 2024
Open
This was referenced Jun 24, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Milestone
8.3.5
Development

Successfully merging this pull request may close these issues.

Document methods are not available when it is populated
2 participants
@vkarpov15 @hasezoey