Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(connection): fix return type of withSession() #14690

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

tt-public
Copy link
Contributor

Summary

This fixes Connection.withSession()'s type definition, which currently doesn't seem to match the implementation [here].

Examples

(a test is added instead)

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 8.4.4 milestone Jun 25, 2024
@vkarpov15 vkarpov15 merged commit f89868b into Automattic:master Jun 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants