Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(model): add Model.applyVirtuals() to apply virtuals to a POJO #14905

Merged
merged 7 commits into from
Sep 26, 2024
Merged

feat(model): add Model.applyVirtuals() to apply virtuals to a POJO #14905

merged 7 commits into from
Sep 26, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14818

Summary

Logic largely copied from https://github.com/mongoosejs/mongoose-lean-virtuals/blob/master/index.js to apply a Model's virtuals to a POJO.

Examples

@hasezoey hasezoey added this to the 8.7 milestone Sep 23, 2024
hasezoey
hasezoey reviewed Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks good to me, some minor style suggestions, aside from that:

  • typescript types for the new applyVirtuals are not added yet
  • there is a distinct lack of documentation in the applyVirtuals file

lib/model.js Show resolved Hide resolved
lib/model.js Show resolved Hide resolved
test/model.test.js Show resolved Hide resolved
lib/helpers/document/applyVirtuals.js Outdated Show resolved Hide resolved
vkarpov15 and others added 4 commits September 24, 2024 17:33
@vkarpov15 @hasezoey
Update lib/model.js
bcbc9e0 
Co-authored-by: hasezoey <hasezoey@gmail.com>
@vkarpov15 @hasezoey
Update lib/model.js
a199929 
Co-authored-by: hasezoey <hasezoey@gmail.com>
@vkarpov15
remove duplicate test
c143d8e
@vkarpov15
docs(applyVirtuals): add jsdoc comments and clean up some unnecessary…
660aad0 
… code
@vkarpov15 vkarpov15 requested a review from hasezoey September 25, 2024 14:29
@vkarpov15
Copy link
Collaborator Author

@hasezoey thanks for the feedback. I added docs and addressed issues 👍

hasezoey
hasezoey reviewed Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, typescript types for the new applyVirtuals on Model are still missing though

hasezoey
hasezoey reviewed Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@vkarpov15 vkarpov15 merged commit a4e3308 into 8.7 Sep 26, 2024
29 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-14818-2 branch September 26, 2024 16:20
@nejidevelops nejidevelops mentioned this pull request Oct 20, 2024
Open
@ShivamNimje6 ShivamNimje6 mentioned this pull request Oct 20, 2024
Open
@zntb zntb mentioned this pull request Oct 21, 2024
Merged
@nejidevelops nejidevelops mentioned this pull request Oct 22, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Oct 23, 2024
Open
@sharma731 sharma731 mentioned this pull request Oct 23, 2024
Open
@axqqt axqqt mentioned this pull request Oct 23, 2024
Open
@zntb zntb mentioned this pull request Oct 24, 2024
Merged
@Tobsukka Tobsukka mentioned this pull request Oct 25, 2024
Open
@k2xl k2xl mentioned this pull request Oct 25, 2024
Open
@hamzabetbaieb hamzabetbaieb mentioned this pull request Oct 25, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request Oct 25, 2024
Open
@AlexanderSCK AlexanderSCK mentioned this pull request Oct 25, 2024
Open
@KovacevicAleksa KovacevicAleksa mentioned this pull request Nov 5, 2024
Merged
@saileshbro saileshbro mentioned this pull request Nov 5, 2024
Merged
@JasperVanNiekerk JasperVanNiekerk mentioned this pull request Nov 5, 2024
Merged
@MSK-009 MSK-009 mentioned this pull request Nov 5, 2024
Open
@zntb zntb mentioned this pull request Nov 6, 2024
Merged
@pradumchintamani pradumchintamani mentioned this pull request Nov 6, 2024
Open
@aditya-arcot aditya-arcot mentioned this pull request Nov 6, 2024
Merged
@NotZarifGithub NotZarifGithub mentioned this pull request Nov 6, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Nov 6, 2024
Open
@lholmquist lholmquist mentioned this pull request Nov 6, 2024
Merged
@issam-seghir issam-seghir mentioned this pull request Nov 6, 2024
Open
@saileshbro saileshbro mentioned this pull request Nov 7, 2024
Merged
@Tobsukka Tobsukka mentioned this pull request Nov 8, 2024
Open
@k2xl k2xl mentioned this pull request Nov 8, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request Nov 8, 2024
Open
@evildevill evildevill mentioned this pull request Nov 8, 2024
Closed
@AlexanderSCK AlexanderSCK mentioned this pull request Nov 8, 2024
Open
@AntenehTsegayeTessema AntenehTsegayeTessema mentioned this pull request Nov 8, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Nov 9, 2024
Open
@zntb zntb mentioned this pull request Nov 9, 2024
Closed
@aviraj1703 aviraj1703 mentioned this pull request Nov 9, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Nov 9, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Nov 10, 2024
Open
@axqqt axqqt mentioned this pull request Nov 10, 2024
Open
@AndrewTroll AndrewTroll mentioned this pull request Nov 11, 2024
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Nov 11, 2024
Open
@axqqt axqqt mentioned this pull request Nov 11, 2024
Open
@sachinthapa572 sachinthapa572 mentioned this pull request Nov 11, 2024
Open
@ST10029788 ST10029788 mentioned this pull request Nov 12, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey left review comments

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.7
Development

Successfully merging this pull request may close these issues.
2 participants
@vkarpov15 @hasezoey