Added strictBool option to schema #5856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
requested changes
Nov 29, 2017
lib/schema/boolean.js
Outdated
| if (value === null) { | ||
| return value; | ||
| } | ||
|
|
||
| if (!this.options.strictBool) { | ||
| if (this.options.strictBool || (model.schema.options.strictBool && this.options.strictBool !== false)) { |
There was a problem hiding this comment.
model might not be defined if we're casting for a query, which is why the tests are failing on travis. Good work thus far but to get this merged we need to figure out what to do with that case so the tests succeed.
|
I've looked at the failing tests and it looks like they are unrelated to the change. Tried running first one locally (gh-5737) and it fails randomly. Maybe a race condition? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Same as #5344 but on Schema level.
Test plan
Include a test.
npm test -- -g 'strictBool': test passed