Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gam): add 1x1 size to all viewports #887

Closed
wants to merge 1 commit into from

Conversation

miguelpeixe
Copy link
Member

Tweaks the approach from #837 so the enforced 1x1 size is not added to the pool of sizes to be calculated for different viewports. The 1x1 should be added to each viewport.

How to test

  1. Make sure you have GAM connected and an ad unit configured with multiple sizes (mobile and desktop) to be rendered on a page
  2. Visit the page with the ?googfc parameter
  3. Confirm the ad unit includes the 1x1 size
  4. Switch to a mobile viewport, refresh the page, and confirm the available sizes changes and 1x1 remains

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant