Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rework search as a block #110

Closed
wants to merge 5 commits into from
Closed

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Closes # .

How to test the changes in this Pull Request:

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@thomasguillot thomasguillot deleted the branch master May 30, 2024 06:19
@laurelfulford
Copy link
Contributor Author

@thomasguillot I still think we should do this to make the search easier to add, but the PR probably does need a fresh start once we start working on this again! 🙂

@thomasguillot
Copy link
Contributor

@laurelfulford Oh no, so sorry, I didn't mean to close this PR. I think it happened when I deleted the master branch 🤦‍♂️. I'll create a new Issue and add a reference to this PR.

@laurelfulford
Copy link
Contributor Author

@thomasguillot It's all good -- I thought the super-old PR might've been driving you nuts 😆 I'm not sure if much was salvageable as is. Thanks for creating a new issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants