Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changes required for Campaigns rearchitecture #1498

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Jul 13, 2023

All Submissions:

Changes proposed in this Pull Request:

All changes required for the Campaigns Rearchitecture initiative. Also requires Automattic/newspack-plugin#2558 and Automattic/newspack-popups#1192.

How to test the changes in this Pull Request:

There should be no functional changes as a result of this changeset, but it does remove the hidden AMP client ID field which was previously a requirement for the Campaigns Lightweight API, since client ID is no longer needed for Campaigns segmentation APIs.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo merged commit 2a722c1 into master Aug 17, 2023
2 checks passed
@dkoo dkoo deleted the epic/campaigns-rearchitecture branch August 17, 2023 20:40
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.74.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.74.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants