Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only show Additional Fields panel when using Stripe platform #1499

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix: only show Additional Fields panel when using Stripe platform #1499

merged 1 commit into from
Jul 17, 2023

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Jul 14, 2023

All Submissions:

Changes proposed in this Pull Request:

The "Additional Fields" panel applies only to the Simplified Donate block, but it's always shown in the block's sidebar in the editor. This fix only shows it if the Reader Revenue platform is Stripe. This condition will have to be changed once we allow the SDB to be used with WooCommerce as well.

How to test the changes in this Pull Request:

  1. On master or release, set your Reader Revenue platform to "Newspack" or anything other than "Stripe".
  2. Add a Donate block to a post or page and observe that the Additional Fields panel is available, but that it won't do anything to the front-end render of the block.
  3. Check out this branch and confirm the Additional Fields panel is now hidden.
  4. Set your Reader Revenue platform to "Stripe", reload the editor, and confirm the Additional Fields panel is available again and lets you add additional fields that are rendered on the front-end, as expected.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added bug Something isn't working [Status] Needs Review labels Jul 14, 2023
@dkoo dkoo requested a review from a team as a code owner July 14, 2023 16:37
@dkoo dkoo self-assigned this Jul 14, 2023
@dkoo dkoo changed the base branch from master to release July 14, 2023 16:38
leogermani
leogermani approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@leogermani leogermani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@dkoo
Copy link
Contributor Author

dkoo commented Jul 14, 2023

Will hold until Monday!

@dkoo dkoo merged commit 1a08513 into release Jul 17, 2023
3 checks passed
@dkoo dkoo deleted the hotfix/additional-fields-panel branch July 17, 2023 16:27
matticbot pushed a commit that referenced this pull request Jul 17, 2023
@semantic-release-bot
chore(release): 1.72.2 [skip ci]
10b2bb1 
## [1.72.2](v1.72.1...v1.72.2) (2023-07-17)

### Bug Fixes

* only show Additional Fields panel when using Stripe platform ([#1499](#1499)) ([1a08513](1a08513))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.72.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jul 17, 2023
@semantic-release-bot
chore(release): 1.73.0-alpha.3 [skip ci]
84b2cc9 
# [1.73.0-alpha.3](v1.73.0-alpha.2...v1.73.0-alpha.3) (2023-07-17)

### Bug Fixes

* only show Additional Fields panel when using Stripe platform ([#1499](#1499)) ([1a08513](1a08513))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.73.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogermani leogermani leogermani approved these changes

Assignees

@dkoo dkoo

Labels
bug Something isn't working released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkoo @matticbot @leogermani