Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(homepage-posts): add a show-full-content attribute #1886

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

adekbadek
Copy link
Member

@adekbadek adekbadek commented Sep 19, 2024

All Submissions:

Changes proposed in this Pull Request:

Adds a "show full content" attribute on the Hompage Posts Block.

How to test the changes in this Pull Request:

  1. Insert a HPB on a page
  2. Observe there's a new setting in "Post Control Settings" sidebar panel
  3. Toggle on "Show Full Content" and observe full post content is displayed
  4. Publish the page, observe the full post content is displayed
  5. Toggle it off, observe it's mutually exclusive with the "Show Excerpt" attribute

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek marked this pull request as ready for review September 19, 2024 11:54
@adekbadek adekbadek merged commit 09619a9 into trunk Sep 20, 2024
9 checks passed
@adekbadek adekbadek deleted the feat/hpb-full-content branch September 20, 2024 11:21
matticbot pushed a commit that referenced this pull request Sep 20, 2024
# [4.2.0-alpha.4](v4.2.0-alpha.3...v4.2.0-alpha.4) (2024-09-20)

### Features

* **homepage-posts:** add a show-full-content attribute ([#1886](#1886)) ([09619a9](09619a9))
* **homepage-posts:** infinite scroll ([#1845](#1845)) ([f5f1c20](f5f1c20))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.2.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Oct 8, 2024
# [4.2.0](v4.1.2...v4.2.0) (2024-10-08)

### Bug Fixes

* we know how long the cache is ([ec5083d](ec5083d))

### Features

* block caching ([62ba143](62ba143))
* **homepage-posts:** add a show-full-content attribute ([#1886](#1886)) ([09619a9](09619a9))
* **homepage-posts:** infinite scroll ([#1845](#1845)) ([f5f1c20](f5f1c20))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants