Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ras-acc): apply wp-block-button class to checkout buttons #1887

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

chickenn00dle
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1207817176293825/1208327956169310/f

This PR fixes an issue where checkout button blocks were losing the wp-block-button class when upgrading to epic/ras-acc.

Screenshot 2024-09-19 at 12 32 26

How to test the changes in this Pull Request:

  1. Make sure trunk is checked out and compiled
  2. Add a checkout button to any post or page
  3. As a reader view the post or page and verify the checkout button has the wp-block-button class as pictured above.
  4. Checkout epic/ras-acc and build
  5. Once again as a reader view the post or page with the checkout button. The wp-block-button class should be missing.
  6. Repeat the above steps, but instead of epic/ras-acc checkout this branch on step 4. This time the wp-block-button class should not be missing.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this did the trick!! 🙌 Thanks @chickenn00dle!

@chickenn00dle chickenn00dle merged commit d136a62 into epic/ras-acc Sep 19, 2024
10 checks passed
@chickenn00dle chickenn00dle deleted the fix/reapply-wp-block-button-class branch September 19, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants