fix: update dependencies to avoid conflict in WP 6.6 #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
chickenn00dle
previously requested changes
Jun 21, 2024
There was a problem hiding this comment.
Hey @dkoo,
Aside from the lint error I commented about, I'm also seeing the listing block is not available when 6.5.4 is installed similar to the blocks PR:
Also similar to the blocks PR, when the block is added to a page with 6.6 installed, when I downgrade to 6.5.4, I see the following error:
| "start": "npm ci && npm run watch", | ||
| "watch": "newspack-scripts wp-scripts start", | ||
| "test": "echo 'No JS unit tests in this repository.'", | ||
| "lint": "npm run lint:scss && npm run lint:js", |
There was a problem hiding this comment.
Running into this error when running this:
Likely related to this comment in slack: p1718927940733569/1718662684.817909-slack-C015W6BES8J
There was a problem hiding this comment.
The stylelint errors should be fixed as of newspack-scripts@5.6.0-alpha.7
miguelpeixe
approved these changes
Aug 2, 2024
matticbot
pushed a commit
that referenced
this pull request
Aug 2, 2024
# [3.0.0-alpha.1](v2.16.0...v3.0.0-alpha.1) (2024-08-02) ### Bug Fixes * update dependencies to support `@wordpress/scripts` ([#457](#457)) ([703e281](703e281)) ### BREAKING CHANGES * Updates dependencies for compatibility with WordPress 6.6.*, but breaks JS in WordPress 6.5.* and below. If you need support for WP 6.5.*, please do not upgrade to this new major version. * chore: refactor for newspack-scripts dependency updates * chore: update webpack config * refactor: use proxy script for eslint and stylelint scripts * fix: peer dependencies * chore: update newspack-scripts to v5.6.0-alpha.3 * chore: remove ajv dependency * chore: add .stylelintrc.js * chore: update newspack-scripts to v5.6.0-alpha.4 * fix: add missing Prettier config files * chore: update newspack-scripts to 5.6.0-alpha.5 * chore: update newspack-scripts to v5.6.0-alpha.7 * chore: update newspack-scripts to v5.6.0-alpha.8 * chore: add NPM scripts for PHP * fix: phpcs * fix: phpcs errors * chore: update newspack-components to v3.0.0 * chore: bump newspack-scripts to v5.5.2
|
🎉 This PR is included in version 3.0.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Aug 13, 2024
# [3.0.0](v2.16.0...v3.0.0) (2024-08-13) ### Bug Fixes * update dependencies to support `@wordpress/scripts` ([#457](#457)) ([703e281](703e281)) ### BREAKING CHANGES * Updates dependencies for compatibility with WordPress 6.6.*, but breaks JS in WordPress 6.5.* and below. If you need support for WP 6.5.*, please do not upgrade to this new major version. * chore: refactor for newspack-scripts dependency updates * chore: update webpack config * refactor: use proxy script for eslint and stylelint scripts * fix: peer dependencies * chore: update newspack-scripts to v5.6.0-alpha.3 * chore: remove ajv dependency * chore: add .stylelintrc.js * chore: update newspack-scripts to v5.6.0-alpha.4 * fix: add missing Prettier config files * chore: update newspack-scripts to 5.6.0-alpha.5 * chore: update newspack-scripts to v5.6.0-alpha.7 * chore: update newspack-scripts to v5.6.0-alpha.8 * chore: add NPM scripts for PHP * fix: phpcs * fix: phpcs errors * chore: update newspack-components to v3.0.0 * chore: bump newspack-scripts to v5.5.2
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Refactoring required for changes in Automattic/newspack-scripts#209. Note that this PR will not pass CI tests and should NOT be merged until Automattic/newspack-scripts#209 is released as an NPM package, so this repo can install it as a dependency.
How to test the changes in this Pull Request:
Follow instructions in Automattic/newspack-scripts#209.
Other information: